chore!: remove merkle library

[cmwaters]

This reverts commit fdf1e92.

Closes: #39

[Wondertan]

Shoot, we haven't decided what we do instead.

[cmwaters]

Shoot, we haven't decided what we do instead.

We're actually not using this library atm (we're still depending on the merkle library in celestia-core). I don't mind if we decide to spin out it's own repo, to make merkle it's own go.mod, or just leave it as is

Actually I'm wrong. We do use it so would have to revert back to celestia-core

[rootulp]

Note: there are usages of go-square/merkle in celestia-app (e.g. here) so I'm guessing those usages will need to be updated to celestia-core merkle instead when celestia-app bumps to go-square v2.

[rootulp]

Seems fine to me. In go-square v2 release notes we should provide guidance to any consumers who use go-square/merkle to migrate to something else (potentially celestia-core merkle)

[cristaloleg]

yay

[Wondertan]

Actually I'm wrong. We do use it so would have to revert back to celestia-core

Just saw the edit. I am strictly against go-square depending on celestia-core, even if the merkle pkg is a separate go.mod inside

[rootulp]

go-square doesn't need to depend on celestia-core b/c nothing breaks if we remove the merkle package in this repo.

[Wondertan]

We do use it so would have to revert back to celestia-core

What does revert back mean?

[rootulp]

I think consumers of go-square/merkle (i.e. celestia-app) would have to revert back to consuming it from celestia-core.

[Wondertan]

I see, I misunderstood the message then