chore!: break out BlobTx and IndexWrapper types into separate tx package #97
Conversation
cmwaters
requested review from
rach-id,
evan-forbes,
cristaloleg and
walldiss
and removed request for
a team
| @@ -7,8 +7,10 @@ | |||
| Package | Description | |||
| ----------|--------------------------------------------------------------------------------------------------------------------- | |||
| inclusion | Package inclusion contains functions to generate the blob share commitment from a given blob. | |||
| proto | Package contains proto definitions and go generated code | |||
There was a problem hiding this comment.
[question] does this proto package actually exist? It looks like the proto definition for BlobTx and IndexWrapper are still inside proto/blob/v1
There was a problem hiding this comment.
put another way: there is no Go package named proto
There was a problem hiding this comment.
No but here is generated code in the proto directory and that's what I was referring to. I'm happy to remove it
There was a problem hiding this comment.
I thought this list was just Go packages but I can see an argument for expanding this list to all directories and not just Go packages
Yeah it seems more logical to separate them but we don't need to |
While updating
celestia-app, it felt out of place that BlobTx and IndexWrapper should be part of thesharespackage. This moves them out