Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: no trailing commas in *.txt files #523

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 1, 2023

Closes #350

Testing

The first commit on rootulp#1 fails this check. The last commit succeeds.

@rootulp rootulp requested review from Bidon15 and jcstein November 1, 2023 19:45
@rootulp rootulp self-assigned this Nov 1, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 6, 2023

@MSevey should the validate_user CI check fail for PRs authored by me?

Ref: https://github.com/celestiaorg/networks/actions/runs/6724345624/job/18276392072?pr=523#step:5:67

@rootulp rootulp requested a review from YazzyYaz November 6, 2023 13:17
@rootulp rootulp enabled auto-merge (squash) November 6, 2023 13:17
@MSevey
Copy link
Member

MSevey commented Nov 7, 2023

@MSevey should the validate_user CI check fail for PRs authored by me?

Ref: https://github.com/celestiaorg/networks/actions/runs/6724345624/job/18276392072?pr=523#step:5:67

yea this is something we can remove now. It was for gentx generation for mainnet.

@MSevey
Copy link
Member

MSevey commented Nov 7, 2023

REF #528

@rootulp rootulp requested review from MSevey and removed request for YazzyYaz November 8, 2023 10:15
@rootulp rootulp merged commit d496745 into celestiaorg:master Nov 10, 2023
@rootulp rootulp deleted the rp/lint-trailing-commas branch November 10, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format of peers.txt changes across testnets
4 participants