feat: update sleep and container name to work on both Mac and Linux #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaces #5
Problem 1
Example on macOS when container is named
nitro-testnode-da-1
:Example on Ubuntu when container is named
nitro-testnode_da_1
:Solution 1
Give the container a name:
da-celestia
, keeping things standard across different OS.4763e34
Problem 2
Using
sleep 100s
on Mac does not run the same way as ubuntu, also, the docker file has 2 different syntax for 2 different sleep commands, with and without thes
.nitro-testnode/test-node.bash
Line 262 in d5635fb
nitro-testnode/test-node.bash
Line 343 in d5635fb
Solution 2
Use standard
sleep x
from the original script, without thes
, allowing this to run on all machines.1d53c49
Checklist