Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sleep and container name to work on both Mac and Linux #10

Merged

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Jan 11, 2024

Overview

Replaces #5

Problem 1

Example on macOS when container is named nitro-testnode-da-1 :

✔ Container nitro-testnode-da-1              Started                   0.6s
Waiting for http://localhost:26659/header/1 to come up..........................................................................Done!
Error response from daemon: No such container: nitro-testnode_da_1

Example on Ubuntu when container is named nitro-testnode_da_1 :

✔ Container nitro-testnode_da_1              Started                   0.6s
Waiting for http://localhost:26659/header/1 to come up..........................................................................Done!
Error response from daemon: No such container: nitro-testnode-da-1

Solution 1

Give the container a name: da-celestia, keeping things standard across different OS.

 ✔ Container da-celestia                      Started                   0.1s
Waiting for http://localhost:26659/header/1 to come up...........................................................Done!
== Generating l1 keys

4763e34

Problem 2

Using sleep 100s on Mac does not run the same way as ubuntu, also, the docker file has 2 different syntax for 2 different sleep commands, with and without the s.

sleep 0.25

sleep 100s

Solution 2

Use standard sleep x from the original script, without the s, allowing this to run on all machines.

1d53c49

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein
Copy link
Member Author

jcstein commented Jan 11, 2024

@jcstein jcstein changed the title feat: update sleep and container name to work on multiple OS feat: update sleep and container name to work on both Mac and Linux Jan 11, 2024
@jcstein jcstein marked this pull request as ready for review January 11, 2024 21:39
jcstein added a commit to celestiaorg/docs that referenced this pull request Jan 11, 2024
@jcstein
Copy link
Member Author

jcstein commented Jan 12, 2024

Reminder: after this is merged, the commit of nitro-testnode on nitro will need updated

Copy link
Collaborator

@Ferret-san Ferret-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Ferret-san Ferret-san merged commit 7714447 into celestiaorg:celestia Jan 12, 2024
1 check passed
@jcstein jcstein deleted the jcs/update-container-name-and-sleep branch January 12, 2024 22:37
Ferret-san pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants