Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v0.13.0 #35

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: add v0.13.0 #35

merged 2 commits into from
Feb 8, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Feb 8, 2024

Overview

Notes from updating:

--> Generating OpenRPC spec
failed to retrieve example value for type: blob.GasPrice on parent 'blob.GasPrice')
{
    "openrpc": "1.2.6",
    "info": {
        "title": "Celestia Node API",
        "description": "The Celestia Node API is the collection of RPC methods that can be used to interact with the services provided by Celestia Data Availability Nodes.",
        "version": "v0.11.0"
    },
  1. no example value for blob.GasPrice
  2. API version is still v0.11.0, which is the same as last few releases, i just ran make openrpc-gen on v0.11.0 and the API version is the same there. this is related to this ticket that is related to api version [Feature Request]: match upcoming node version with API celestia-node#2549
--> Generating OpenRPC spec
{
    "openrpc": "1.2.6",
    "info": {
        "title": "Celestia Node API",
        "description": "The Celestia Node API is the collection of RPC methods that can be used to interact with the services provided by Celestia Data Availability Nodes.",
        "version": "v0.11.0"
    },

Storing openrpc.json in main would allow for this to have validation before being published, and a history to exist for maintainers of node-rpc-docs. celestiaorg/celestia-node#2611

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein self-assigned this Feb 8, 2024
@jcstein jcstein requested a review from ramin February 8, 2024 14:52
@jcstein
Copy link
Member Author

jcstein commented Feb 8, 2024

resolved in a hotfix to this Spec. PR has been made to push this fix to celestia-node

@jcstein jcstein merged commit 3b3977b into main Feb 8, 2024
5 checks passed
@jcstein jcstein deleted the jcs/add-v0.13.0 branch April 12, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant