Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump @grpc/grpc-js from 1.8.0 to 1.8.17 #164

Open
wants to merge 54 commits into
base: celestia-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
f4998ee
da: use celestia as da
tuxcanfly Apr 21, 2023
54c1052
batcher: fix duplicate cli flag name
tuxcanfly Apr 25, 2023
d7cf0bb
docker: use latest devnet image
tuxcanfly Apr 26, 2023
146d21c
bump local celestia devnet to 0.9.1
tuxcanfly Apr 26, 2023
80977ae
docker: wait for da to boot
tuxcanfly Apr 27, 2023
82d4fee
op-ndoe: decodeeETHData - use uint32 for height
tuxcanfly Apr 27, 2023
884fd58
proposer: fix da rpc, estimate gas
tuxcanfly Apr 28, 2023
29c04d1
op-node: fix failed to parse frame error
tuxcanfly Apr 28, 2023
83e4fb9
proposer: fix revert
tuxcanfly May 2, 2023
249d312
proposer: restore gas limit; add explanation
tuxcanfly May 3, 2023
bcf0845
proposer: nit
tuxcanfly May 3, 2023
c4080a0
add celestia logo, update readme
jcstein May 3, 2023
73a4651
Update README.md
jcstein May 3, 2023
a536860
style size
jcstein May 3, 2023
544bb81
plus not x
jcstein May 3, 2023
1a3ed81
docs: edit intro
jcstein May 3, 2023
7550915
Update README.md
jcstein May 3, 2023
99b2a9b
Update README.md
jcstein May 3, 2023
3591a20
Merge pull request #33 from celestiaorg/jcs/update-readme
jcstein May 3, 2023
f073f20
nit
jcstein May 3, 2023
c33c5a0
Merge pull request #34 from celestiaorg/jcs/update-readme
jcstein May 3, 2023
4f73953
docs: add section on deposit bridge
jcstein May 3, 2023
d4f66d0
add workaround from @Ferret-san
jcstein May 3, 2023
6b45c90
close code block
jcstein May 3, 2023
e24f0b1
fix: typo
jcstein May 3, 2023
6dd4495
Update README.md
jcstein May 4, 2023
320b34a
docs: add bridging section from guidance from @Ferret-san
jcstein May 4, 2023
ccee67b
Merge pull request #35 from celestiaorg/jcs/bridge
jcstein May 4, 2023
1cdb0b8
deps: bump local-devnet to 0.9.2
jcstein May 4, 2023
9837663
Merge pull request #36 from celestiaorg/jcs/bump-local-devnet
jcstein May 4, 2023
b0519b4
docker: fix da container name
tuxcanfly May 4, 2023
d0280e1
op-node: gracefully retry da connection err
tuxcanfly May 10, 2023
8f48706
test: update e2e tests for celestia da
tuxcanfly May 15, 2023
7f3cca5
docs: update readme
jcstein May 15, 2023
102c5e2
deps: update local-celestia-devnet to v0.9.5
jcstein May 15, 2023
f05b485
Merge pull request #46 from celestiaorg/jcs/devnet-ver-bump
jcstein May 15, 2023
cb82872
Add DALC support (#47)
jcstein May 17, 2023
e71c751
fix: update path to node store (#52)
jcstein May 19, 2023
5b663de
devnet: increase block times (#50)
tuxcanfly May 19, 2023
1fa2312
.github: add dependabot
MSevey May 23, 2023
cebd51e
Merge pull request #61 from celestiaorg/sevey/dependabot
MSevey May 23, 2023
8f53660
deps: bump celestia-node & local-celestia-devnet image version to v0.…
jcstein May 23, 2023
5b97ddc
op-node: log namespaced data details (#94)
tuxcanfly May 23, 2023
521cd32
Dependabot and Fork Sync (#93)
MSevey May 24, 2023
37a4442
fix: resolve `max_subscriptions` and` share sequence` errors (#120)
jcstein May 26, 2023
a946f39
docs: add wiki to README
jcstein May 30, 2023
a5f8a9a
Merge pull request #130 from celestiaorg/jcs/add-wiki
MSevey May 30, 2023
8d625e9
proposer: allow non finalized true -> false (#133)
tuxcanfly Jun 1, 2023
d90765a
deps: update to node RC for Arabica (#132)
jcstein Jun 1, 2023
693f659
deps: bump celestia-node to v0.11.0-rc2 (#137)
jcstein Jun 5, 2023
de03b37
deps: remove trailing slash (#139)
jcstein Jun 5, 2023
5c9b975
op-node: continue on retrieval error (#142)
tuxcanfly Jun 6, 2023
4b7b01f
op-node: calldata source - reset pipeline on err (#144)
tuxcanfly Jun 7, 2023
a3936b8
build(deps): bump @grpc/grpc-js from 1.8.0 to 1.8.17
dependabot[bot] Jul 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
op-node: calldata source - reset pipeline on err (#144)
  • Loading branch information
tuxcanfly authored Jun 7, 2023
commit 4b7b01f8b54667c19c3c641430900e8c1a2db882
22 changes: 11 additions & 11 deletions op-node/rollup/derive/calldata_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func NewDataSourceFactory(log log.Logger, cfg *rollup.Config, daCfg *rollup.DACo
}

// OpenData returns a DataIter. This struct implements the `Next` function.
func (ds *DataSourceFactory) OpenData(ctx context.Context, id eth.BlockID, batcherAddr common.Address) DataIter {
func (ds *DataSourceFactory) OpenData(ctx context.Context, id eth.BlockID, batcherAddr common.Address) (DataIter, error) {
return NewDataSource(ctx, ds.log, ds.cfg, ds.daCfg, ds.fetcher, id, batcherAddr)
}

Expand All @@ -64,7 +64,7 @@ type DataSource struct {

// NewDataSource creates a new calldata source. It suppresses errors in fetching the L1 block if they occur.
// If there is an error, it will attempt to fetch the result on the next call to `Next`.
func NewDataSource(ctx context.Context, log log.Logger, cfg *rollup.Config, daCfg *rollup.DAConfig, fetcher L1TransactionFetcher, block eth.BlockID, batcherAddr common.Address) DataIter {
func NewDataSource(ctx context.Context, log log.Logger, cfg *rollup.Config, daCfg *rollup.DAConfig, fetcher L1TransactionFetcher, block eth.BlockID, batcherAddr common.Address) (DataIter, error) {
_, txs, err := fetcher.InfoAndTxsByHash(ctx, block.Hash)
if err != nil {
return &DataSource{
Expand All @@ -74,7 +74,7 @@ func NewDataSource(ctx context.Context, log log.Logger, cfg *rollup.Config, daCf
fetcher: fetcher,
log: log,
batcherAddr: batcherAddr,
}
}, nil
} else {
data, err := DataFromEVMTransactions(cfg, daCfg, batcherAddr, txs, log.New("origin", block))
if err != nil {
Expand All @@ -85,12 +85,12 @@ func NewDataSource(ctx context.Context, log log.Logger, cfg *rollup.Config, daCf
fetcher: fetcher,
log: log,
batcherAddr: batcherAddr,
}
}, err
}
return &DataSource{
open: true,
data: data,
}
}, nil
}
}

Expand All @@ -103,7 +103,8 @@ func (ds *DataSource) Next(ctx context.Context) (eth.Data, error) {
ds.open = true
ds.data, err = DataFromEVMTransactions(ds.cfg, ds.daCfg, ds.batcherAddr, txs, log.New("origin", ds.id))
if err != nil {
return nil, NewTemporaryError(fmt.Errorf("failed to open calldata source: %w", err))
// already wrapped
return nil, err
}
} else if errors.Is(err, ethereum.NotFound) {
return nil, NewResetError(fmt.Errorf("failed to open calldata source: %w", err))
Expand Down Expand Up @@ -143,15 +144,14 @@ func DataFromEVMTransactions(config *rollup.Config, daCfg *rollup.DAConfig, batc
height, index, err := decodeETHData(tx.Data())
if err != nil {
log.Warn("unable to decode data pointer", "index", j, "err", err)
continue
return nil, err
}
log.Warn("requesting celestia namespaced data", "namespace", hex.EncodeToString(daCfg.Namespace.Bytes()), "height", height)
log.Info("requesting data from celestia", "namespace", hex.EncodeToString(daCfg.Namespace.Bytes()), "height", height)
data, err := daCfg.Client.NamespacedData(context.Background(), daCfg.Namespace, uint64(height))
if err != nil {
log.Warn("unable to retrieve data from da", "err", err)
continue
return nil, NewResetError(fmt.Errorf("failed to retrieve data from celestia: %w", err))
}
log.Warn("retrieved data", "data", hex.EncodeToString(data[index]))
log.Debug("retrieved data", "data", hex.EncodeToString(data[index]))
out = append(out, data[index])
} else {
out = append(out, tx.Data())
Expand Down
9 changes: 6 additions & 3 deletions op-node/rollup/derive/l1_retrieval.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
)

type DataAvailabilitySource interface {
OpenData(ctx context.Context, id eth.BlockID, batcherAddr common.Address) DataIter
OpenData(ctx context.Context, id eth.BlockID, batcherAddr common.Address) (DataIter, error)
}

type NextBlockProvider interface {
Expand Down Expand Up @@ -53,7 +53,10 @@ func (l1r *L1Retrieval) NextData(ctx context.Context) ([]byte, error) {
} else if err != nil {
return nil, err
}
l1r.datas = l1r.dataSrc.OpenData(ctx, next.ID(), l1r.prev.SystemConfig().BatcherAddr)
l1r.datas, err = l1r.dataSrc.OpenData(ctx, next.ID(), l1r.prev.SystemConfig().BatcherAddr)
if err != nil {
return nil, err
}
}

l1r.log.Debug("fetching next piece of data")
Expand All @@ -73,7 +76,7 @@ func (l1r *L1Retrieval) NextData(ctx context.Context) ([]byte, error) {
// Note that we open up the `l1r.datas` here because it is requires to maintain the
// internal invariants that later propagate up the derivation pipeline.
func (l1r *L1Retrieval) Reset(ctx context.Context, base eth.L1BlockRef, sysCfg eth.SystemConfig) error {
l1r.datas = l1r.dataSrc.OpenData(ctx, base.ID(), sysCfg.BatcherAddr)
l1r.datas, _ = l1r.dataSrc.OpenData(ctx, base.ID(), sysCfg.BatcherAddr)
l1r.log.Info("Reset of L1Retrieval done", "origin", base)
return io.EOF
}