Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

ci: add support for codeql #504

Merged
merged 3 commits into from
Oct 10, 2023
Merged

ci: add support for codeql #504

merged 3 commits into from
Oct 10, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 3, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the CI/CD label Oct 3, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner October 3, 2023 13:44
@rach-id rach-id self-assigned this Oct 3, 2023
evan-forbes
evan-forbes previously approved these changes Oct 5, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but we should ofc either fix the failure here, open an issue to fix it

Comment on lines +17 to +19
pull_request:
# The branches below must be a subset of the branches above
branches: [ "main" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run this per PR push since I thought that most of the time this should just error because a dependency is out of date, and perhaps not because a PR includes new deps. Could be wrong, but I think keeping the ci shorter and simpler is worth it provided we still fix the problematic deps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now is fixed, so this can be merged

@rach-id rach-id enabled auto-merge (squash) October 10, 2023 11:33
@rach-id rach-id requested a review from evan-forbes October 10, 2023 11:33
@rach-id rach-id merged commit e0c00ec into main Oct 10, 2023
17 checks passed
@rach-id rach-id deleted the SweeXordious-patch-1 branch October 10, 2023 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants