-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
WalkthroughThe changes primarily revolve around the update of the Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (4)
- e2e/go.mod
- e2e/go.sum
- go.mod
- go.sum
Files selected for processing (7)
- benchmark/main.go (1 hunks)
- cmd/blobstream/deploy/cmd.go (3 hunks)
- cmd/blobstream/relayer/cmd.go (1 hunks)
- e2e/qgb_network.go (1 hunks)
- evm/evm_client.go (2 hunks)
- evm/evm_client_test.go (1 hunks)
- relayer/relayer.go (1 hunks)
Files skipped from review due to trivial changes (1)
- relayer/relayer.go
Additional comments: 9
cmd/blobstream/relayer/cmd.go (1)
- 8-8: The import path for the
Blobstream.sol
file has been updated from version 3 to version 4. Ensure that the new version of the contract is compatible with the rest of the codebase and that all necessary changes have been made to accommodate this update.benchmark/main.go (1)
- 13-13: The import path for the Blobstream contract has been updated from version 3 to version 4. Ensure that the new version of the contract is compatible with the rest of the codebase and that all necessary changes have been made to accommodate any differences in the contract's interface or functionality.
evm/evm_client_test.go (1)
- 6-12: The import path for the Blobstream contract has been updated from version 3 to version 4. Ensure that the new version of the contract is compatible with the rest of the codebase.
cmd/blobstream/deploy/cmd.go (3)
76-86: The error handling for
parseStartingNonce
is correctly implemented. It checks for errors and returns them if any occur.128-134: The
DeployBlobstreamContract
function is correctly called with the parsedstartingNonce
. The error handling for this function call is also correctly implemented.201-225: The
parseStartingNonce
function is correctly implemented. It handles the cases for "latest", "earliest", and a specific nonce value. It also correctly parses the nonce value from a string to a uint64 and handles any errors that may occur during this process.evm/evm_client.go (2)
13-20: The import paths for the
blobstreamwrapper
andproxywrapper
packages have been updated from version 3 to version 4. Ensure that the new versions of these packages are compatible with the rest of the codebase.85-99: The
ethVsHash
variable has been renamed toethVsCheckpoint
and the corresponding function calls and parameters have been updated to reflect this change. Theinitialize
function call now usesethVsCheckpoint
instead ofethVsHash
as a parameter. Ensure that this change is reflected in all parts of the codebase where these variables and functions are used.e2e/qgb_network.go (1)
- 22-22: The import path for the
Blobstream.sol
contract has been updated from version 3 to version 4. Ensure that all changes in the new version of the contract are compatible with the rest of the codebase.- blobstreamwrapper "github.com/celestiaorg/blobstream-contracts/v3/wrappers/Blobstream.sol" + blobstreamwrapper "github.com/celestiaorg/blobstream-contracts/v4/wrappers/Blobstream.sol"
Overview
Checklist
Summary by CodeRabbit
ethVsHash
variable toethVsCheckpoint
and updated corresponding function calls and parameters.