Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore(deps): bump blobstream to v4 #582

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 9, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Introduced a function to parse the provided starting nonce, allowing for "latest", "earliest", or a specific nonce value.
  • Updates
    • Updated the Blobstream contract from version 3 to version 4 across various parts of the application.
    • Modified the ethVsHash variable to ethVsCheckpoint and updated corresponding function calls and parameters.
  • Bug Fixes
    • Added error handling for parsing the starting nonce.

@rach-id rach-id added the dependencies Pull requests that update a dependency file label Nov 9, 2023
@rach-id rach-id self-assigned this Nov 9, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner November 9, 2023 13:10
Copy link
Contributor

coderabbitai bot commented Nov 9, 2023

Walkthrough

The changes primarily revolve around the update of the Blobstream.sol contract from version 3 to version 4 across multiple files. This update likely brings changes to the contract's interface and functionality. Additionally, a new function for parsing the starting nonce has been introduced, and the ethVsHash variable has been updated to ethVsCheckpoint in the EVM client.

Changes

File Change Summary
benchmark/main.go, cmd/blobstream/relayer/cmd.go, e2e/qgb_network.go, evm/evm_client.go, evm/evm_client_test.go, relayer/relayer.go Updated the import path for Blobstream.sol from version 3 to version 4, indicating an update to the contract version.
cmd/blobstream/deploy/cmd.go Introduced a new function parseStartingNonce for parsing the provided starting nonce. Updated the Command function to include the parsing of starting nonce and use it in the DeployBlobstreamContract call. Added error handling for parsing the starting nonce.
evm/evm_client.go Updated the ethVsHash variable to ethVsCheckpoint and modified corresponding function calls and parameters.

Poem

🍂 As the leaves fall, we code through it all, 🍁

Version 4 is here, bringing cheer and a small tear, 🎉

From 3 we part, with a slightly heavy heart. 💔

But fear not, for change is an art, 🎨

In the world of code, it's a vital part. 💻

So here's to the nonce, and the checkpoint's response, 🥂

To the contracts we update, and the bugs we eliminate. 🐛

On this day in history, we celebrate our victory, 🏆

Coding through the seasons, for countless reasons. 🌍

So hop along, to the rhythm of the code song, 🎵

With each new version, our code grows strong. 💪


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 68b3325 and a16b7c7.
Files ignored due to filter (4)
  • e2e/go.mod
  • e2e/go.sum
  • go.mod
  • go.sum
Files selected for processing (7)
  • benchmark/main.go (1 hunks)
  • cmd/blobstream/deploy/cmd.go (3 hunks)
  • cmd/blobstream/relayer/cmd.go (1 hunks)
  • e2e/qgb_network.go (1 hunks)
  • evm/evm_client.go (2 hunks)
  • evm/evm_client_test.go (1 hunks)
  • relayer/relayer.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • relayer/relayer.go
Additional comments: 9
cmd/blobstream/relayer/cmd.go (1)
  • 8-8: The import path for the Blobstream.sol file has been updated from version 3 to version 4. Ensure that the new version of the contract is compatible with the rest of the codebase and that all necessary changes have been made to accommodate this update.
benchmark/main.go (1)
  • 13-13: The import path for the Blobstream contract has been updated from version 3 to version 4. Ensure that the new version of the contract is compatible with the rest of the codebase and that all necessary changes have been made to accommodate any differences in the contract's interface or functionality.
evm/evm_client_test.go (1)
  • 6-12: The import path for the Blobstream contract has been updated from version 3 to version 4. Ensure that the new version of the contract is compatible with the rest of the codebase.
cmd/blobstream/deploy/cmd.go (3)
  • 76-86: The error handling for parseStartingNonce is correctly implemented. It checks for errors and returns them if any occur.

  • 128-134: The DeployBlobstreamContract function is correctly called with the parsed startingNonce. The error handling for this function call is also correctly implemented.

  • 201-225: The parseStartingNonce function is correctly implemented. It handles the cases for "latest", "earliest", and a specific nonce value. It also correctly parses the nonce value from a string to a uint64 and handles any errors that may occur during this process.

evm/evm_client.go (2)
  • 13-20: The import paths for the blobstreamwrapper and proxywrapper packages have been updated from version 3 to version 4. Ensure that the new versions of these packages are compatible with the rest of the codebase.

  • 85-99: The ethVsHash variable has been renamed to ethVsCheckpoint and the corresponding function calls and parameters have been updated to reflect this change. The initialize function call now uses ethVsCheckpoint instead of ethVsHash as a parameter. Ensure that this change is reflected in all parts of the codebase where these variables and functions are used.

e2e/qgb_network.go (1)
  • 22-22: The import path for the Blobstream.sol contract has been updated from version 3 to version 4. Ensure that all changes in the new version of the contract are compatible with the rest of the codebase.
- blobstreamwrapper "github.com/celestiaorg/blobstream-contracts/v3/wrappers/Blobstream.sol"
+ blobstreamwrapper "github.com/celestiaorg/blobstream-contracts/v4/wrappers/Blobstream.sol"

evm/evm_client.go Dismissed Show dismissed Hide dismissed
@rach-id rach-id enabled auto-merge (squash) November 9, 2023 13:39
@rach-id rach-id merged commit 29598b1 into celestiaorg:main Nov 9, 2023
18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants