-
Notifications
You must be signed in to change notification settings - Fork 16
docs: improve orchestrator documentation #592
Conversation
WalkthroughThe recent update enhances an orchestrator tool with the ability to import private keys using BIP39 mnemonics, improves clarity on resolving gRPC authentication issues and pruned attestations, and introduces a renaming of commands for EVM address handling, changing Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/orchestrator.md (4 hunks)
Additional comments: 4
docs/orchestrator.md (4)
95-98: The addition of BIP39 mnemonic support for importing EVM private keys is a significant enhancement for user security and key recoverability. Ensure that the documentation provides clear instructions on how to use this feature and that any necessary warnings about key security are included.
145-159: The clarification on known issues is helpful for troubleshooting. It's important to ensure that the solutions provided are up-to-date and have been tested to work with the current version of the software. Additionally, consider adding links to any relevant issues in the project's issue tracker for users who want more detailed information.
175-187: The renaming of commands from
blobstream
toqgb
is a critical update for users following the documentation. It's essential to ensure that all instances of the old command name have been updated throughout the documentation to prevent confusion.272-278: The instructions for verifying the updated EVM address are clear. It's good practice to remind users to restart the orchestrator after making changes to ensure that the new configuration is applied.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 26.63% 26.63%
=======================================
Files 29 29
Lines 2962 2962
=======================================
Hits 789 789
Misses 2078 2078
Partials 95 95 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have one suggestion
Overview
Checklist
Summary by CodeRabbit
New Features
Documentation