-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
`gomod e2e` isn't a valid package ecosystem. The valid package ecosystems are listed [here](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem). I think it should just be `gomod`.
WalkthroughThe update to the Changes
Assessment against linked issues (Beta)
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/dependabot.yml (1 hunks)
Additional comments: 1
.github/dependabot.yml (1)
- 24-30: The removal of the
directory: "e2e"
line indicates that Dependabot will no longer be limited to thee2e
directory for Go module updates. This change aligns with the standard practice of having Dependabot check the root directory for Go module updates unless there's a specific reason to target a subdirectory. If thee2e
directory contained a separatego.mod
file for end-to-end tests and it's intended to be updated separately, this change might not be correct. Otherwise, the update is appropriate.
I don't believe the CodeRabbit review here |
Closes #595
gomod e2e
isn't a valid package ecosystem. The valid package ecosystems are listed here. I think it should just begomod
.I haven't tested this yet but it seems safe to just ship it and observe dependabot PRs in this repo after it merges.
Summary by CodeRabbit