Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore: dependabot for e2e #597

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore: dependabot for e2e #597

merged 1 commit into from
Nov 17, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Nov 17, 2023

Closes #595

gomod e2e isn't a valid package ecosystem. The valid package ecosystems are listed here. I think it should just be gomod.

I haven't tested this yet but it seems safe to just ship it and observe dependabot PRs in this repo after it merges.

Summary by CodeRabbit

  • Chores
    • Updated dependency management settings to focus on the main module ecosystem.

`gomod e2e` isn't a valid package ecosystem. The valid package ecosystems are listed [here](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem). I think it should just be `gomod`.
Copy link
Contributor

coderabbitai bot commented Nov 17, 2023

Walkthrough

The update to the .github/dependabot.yml configuration file refines the scope of Dependabot's package ecosystem from including an end-to-end test directory to focusing solely on the Go modules at the project's root. This change suggests an attempt to streamline dependency updates and possibly integrate go mod tidy for the main go.mod without specifying a separate directory for end-to-end tests.

Changes

File Change Summary
.github/dependabot.yml Updated package-ecosystem from "gomod e2e" to "gomod" and removed the "e2e" directory field.

Assessment against linked issues (Beta)

Objective Addressed Explanation
#595: Ensure Dependabot runs go mod tidy on both go.mod files The change removes the directory specification for e2e tests, which could mean Dependabot will no longer check the e2e directory's go.mod file.
#595: Verify Dependabot updates dependencies and tidies both go.mod files The removal of the e2e directory from the configuration does not align with the objective of updating both go.mod files.

Poem

As autumn leaves fall, a rabbit hops along,
Code now tidy, with Dependabot's song.
No more clutter in the e2e test bed,
Just clean updates where the codebase is led. 🍂🐰🎶


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@rootulp rootulp changed the title fix: dependabot for e2e build: dependabot for e2e Nov 17, 2023
@coderabbitai coderabbitai bot changed the title build: dependabot for e2e fix: dependabot for e2e Nov 17, 2023
@rootulp rootulp changed the title fix: dependabot for e2e chore: dependabot for e2e Nov 17, 2023
@rootulp rootulp added the chore label Nov 17, 2023
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 17b5716 and c8179d1.
Files selected for processing (1)
  • .github/dependabot.yml (1 hunks)
Additional comments: 1
.github/dependabot.yml (1)
  • 24-30: The removal of the directory: "e2e" line indicates that Dependabot will no longer be limited to the e2e directory for Go module updates. This change aligns with the standard practice of having Dependabot check the root directory for Go module updates unless there's a specific reason to target a subdirectory. If the e2e directory contained a separate go.mod file for end-to-end tests and it's intended to be updated separately, this change might not be correct. Otherwise, the update is appropriate.

@rootulp rootulp self-assigned this Nov 17, 2023
@rootulp
Copy link
Contributor Author

rootulp commented Nov 17, 2023

I don't believe the CodeRabbit review here

@rach-id rach-id merged commit bf4b1b2 into celestiaorg:main Nov 17, 2023
18 of 19 checks passed
@rootulp rootulp deleted the patch-2 branch November 17, 2023 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix dependabot not applying go mod tidy on e2e directory
2 participants