Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

docs: remove flag that is not used #614

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Nov 22, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Documentation
    • Updated the deployment guide to reflect the simplified deployment process, removing the need for specifying the contract address manually.

Copy link
Contributor

coderabbitai bot commented Nov 22, 2023

Walkthrough

The update to the deployment documentation signifies a simplification in the deployment process for the blobstream command. The removal of the --evm.contract-address flag suggests that users no longer need to manually specify a contract address when deploying, which could mean the system now automatically handles this aspect of the deployment.

Changes

File Path Change Summary
docs/deploy.md Removed the --evm.contract-address flag from the blobstream deploy command.

Poem

As autumn leaves fall, we simplify code,
No more contract address on the deploy road.
🍂 With each command, we aim to please,
🐰 Hopping through updates with the greatest of ease.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0508c24 and 02e69ff.
Files selected for processing (1)
  • docs/deploy.md (1 hunks)
Additional comments: 1
docs/deploy.md (1)
  • 59-64: The --evm.contract-address flag has been removed from the blobstream deploy command. Ensure that the deployment process is correctly obtaining the contract address through other means and that all documentation reflects this change accurately. If there are any other references to this flag in the documentation or codebase, they should be updated or removed accordingly.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0508c24) 26.13% compared to head (02e69ff) 26.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   26.13%   26.13%           
=======================================
  Files          29       29           
  Lines        3019     3019           
=======================================
  Hits          789      789           
  Misses       2135     2135           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rach-id rach-id changed the title fix: remove flag that is not used docs: remove flag that is not used Nov 22, 2023
@rach-id rach-id added the documentation Improvements or additions to documentation label Nov 22, 2023
@rach-id rach-id enabled auto-merge (squash) November 22, 2023 15:25
@rach-id rach-id merged commit 33f7618 into celestiaorg:main Nov 22, 2023
17 of 18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants