-
Notifications
You must be signed in to change notification settings - Fork 16
docs: document updating the EVM address for validators #617
docs: document updating the EVM address for validators #617
Conversation
WalkthroughThe recent updates focus on orchestrator management, particularly addressing scenarios involving the loss of a private key associated with an EVM address. It provides a method for re-registering a new EVM address and guidance on running multiple orchestrators on a single machine by using different P2P ports. Additionally, there's a minor typographical correction in the README related to the Go version number. Changes
TipsChat with CodeRabbit Bot (
|
@@ -215,61 +215,7 @@ code: 0 | |||
codespace: "" | |||
data: 12300A2E2F63656C65737469612E7167622E76312E4D7367526567697374657245564D41646472657373526573706F6E7365 | |||
events: | |||
- attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[note to reviewers]
I think this is just noise in the documentation that requires readers to scroll unnecessarily to continue reading. It doesn't have any important information, so I deleted it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 26.13% 26.13%
=======================================
Files 29 29
Lines 3019 3019
=======================================
Hits 789 789
Misses 2135 2135
Partials 95 95 ☔ View full report in Codecov by Sentry. |
@@ -215,61 +215,7 @@ code: 0 | |||
codespace: "" | |||
data: 12300A2E2F63656C65737469612E7167622E76312E4D7367526567697374657245564D41646472657373526573706F6E7365 | |||
events: | |||
- attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
Co-authored-by: Josh Stein <[email protected]>
Co-authored-by: Josh Stein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/orchestrator.md (2 hunks)
Additional comments: 1
docs/orchestrator.md (1)
- 244-257: The instructions for updating the EVM address, running a second orchestrator on the same machine, and setting up a
systemd
service are clear and well-documented. The note about validator set changes is particularly useful for understanding the expected behavior of the orchestrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/orchestrator.md (2 hunks)
Additional comments: 3
docs/orchestrator.md (3)
218-224: The addition of the ellipsis (
...
) clarifies that the command output is truncated, which addresses the previous concern about the output appearing incomplete.250-256: The new instructions for updating the EVM address and running multiple orchestrators on the same machine are clear and provide valuable guidance for validators.
247-249: The summary mentions information on how to handle changes in the validator set, but there is no specific section in the provided file that addresses this. Please verify if this information is included elsewhere or if the summary needs to be updated.
* feat: match celestiaorg/orchestrator-relayer#617 * Update nodes/blobstream-bootstrapper.md
Overview
Checklist
Summary by CodeRabbit
Documentation
systemd
service.Bug Fixes