Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

feat: support sending EIP1559 transactions depending on the target chain #652

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Dec 7, 2023

Overview

Not setting the gas price at this level allows the wrappers to automatically check if the target chain is EIP 1559 compatible or not and then send the correct transaction.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Refactor

    • Updated the Ethereum transaction process to streamline gas price handling. (Note: The specific method of gas price estimation may now differ from previous versions.)
  • Chores

    • Internal code optimizations for Ethereum transaction execution.

@rach-id rach-id added enhancement New feature or request relayer relayer related labels Dec 7, 2023
@rach-id rach-id self-assigned this Dec 7, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner December 7, 2023 13:28
Copy link
Contributor

coderabbitai bot commented Dec 7, 2023

Walkthrough

The change involves the removal of code that automatically fetched and set the gas price for Ethereum transactions. This suggests a shift towards a different mechanism for handling gas prices, possibly relying on manual specification or a new pricing strategy.

Changes

File Change Summary
evm/evm_transaction_opts.go Removed automatic gas price fetching and setting from Ethereum client.

🐇💻
Code hops away, gas price at bay,
No more fetch, a new path we sketch.
In the blockchain burrow, we find our way,
Crafting transactions, come what may. 🥕🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e7f399e and 5023617.
Files selected for processing (1)
  • evm/evm_transaction_opts.go (1 hunks)
Additional comments: 1
evm/evm_transaction_opts.go (1)
  • 36-43: The changes in the newTransactOptsBuilder function reflect the removal of static gas price setting, aligning with the PR's objective to support EIP1559 transactions. Ensure that the underlying wrappers are correctly determining the transaction type based on the target chain's compatibility with EIP1559, as this logic is not visible in the provided hunk.

@rach-id rach-id merged commit deaace3 into main Dec 7, 2023
18 checks passed
@rach-id rach-id deleted the remove-gas-price-calc branch December 7, 2023 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request relayer relayer related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants