support function overloading with different arguments

cell-labs · Sep 20, 2024 · 201c4b7 · 201c4b7
1 parent 1b6ce6a
commit 201c4b7
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/compiler/compiler/func.go b/compiler/compiler/func.go
@@ -84,9 +84,9 @@ func (c *Compiler) funcType(params, returnTypes []parser.TypeNode, isMethod bool
 }
 
 // ABI description
-// method:			package + _method_ + type + _ + name
-// named function: 	package + name
-// cffi(extern):	function_name
+// method:			package + _method_ + type + _ + name + args
+// named function: 	package + name + args
+// cffi(extern):	function_name + args
 // lambda:			package + anonName
 func (c *Compiler) compileDefineFuncNode(v *parser.DefineFuncNode) value.Value {
 	var compiledName string
@@ -120,8 +120,15 @@ func (c *Compiler) compileDefineFuncNode(v *parser.DefineFuncNode) value.Value {
 	}
 
 	argTypes := make([]parser.TypeNode, len(v.Arguments))
+	argTypesName := ""
 	for k, v := range v.Arguments {
 		argTypes[k] = v.Type
+		argTypesName += v.Type.Type()
+	}
+
+	// add arguments types to support overloading
+	if !v.IsExtern {
+		compiledName += argTypesName
 	}
 
 	retTypes := make([]parser.TypeNode, len(v.ReturnValues))
@@ -161,7 +168,7 @@ func (c *Compiler) compileDefineFuncNode(v *parser.DefineFuncNode) value.Value {
 		LlvmReturnType: funcRetType,
 		ReturnTypes:    treReturnTypes,
 		IsVariadic:     isVariadicFunc,
-		IsExtern:		v.IsExtern,
+		IsExtern:       v.IsExtern,
 		ArgumentTypes:  treParams,
 	}
 
@@ -560,7 +567,6 @@ func (c *Compiler) compileCallNode(v *parser.CallNode) value.Value {
 			}
 		}
 
-
 		llvmArgs[i] = val
 	}
 

diff --git a/tests/examples/func.cell b/tests/examples/func.cell
@@ -1,5 +1,24 @@
 package main
 import "debug"
+
+type A table {}
+
+func (a *A) bar(a uint32) {
+
+}
+
+func (a *A) bar(a uint64) {
+
+}
+
+func foo(a uint32) {
+
+}
+
+func foo(a uint64) {
+
+}
+
 func main() {
 	hi := func() int64 {
 		return 999