Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useSafe for governance:propose and governance:withdraw #511

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Jan 17, 2025


PR-Codex overview

This PR enhances the governance commands in the CLI by adding support for a new useSafe flag, which allows transactions to be executed through SAFE. It also improves documentation and adds checks for safe ownership in governance-related commands.

Detailed summary

  • Updated --useSafe flag description in governance/approve.ts and documentation.
  • Added useSafe and safeAddress flags to SafeFlags in flags.ts.
  • Enhanced safeTransactionMetadataFromCeloTransactionObject function to accept a value parameter.
  • Integrated useSafe checks in Withdraw and Propose commands.
  • Added tests for using SAFE in withdraw-l2.test.ts and propose-l2.test.ts.
  • Included setup instructions for SAFE contracts in multisigUtils.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nicolasbrugneaux nicolasbrugneaux self-assigned this Jan 17, 2025
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 1e1adae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.17%. Comparing base (f76274f) to head (1e1adae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   76.31%   76.17%   -0.14%     
==========================================
  Files         246      246              
  Lines       10386    10410      +24     
  Branches     1639     1651      +12     
==========================================
+ Hits         7926     7930       +4     
- Misses       2373     2374       +1     
- Partials       87      106      +19     
Components Coverage Δ
celocli 86.13% <96.66%> (-0.43%) ⬇️
sdk 68.96% <ø> (ø)
wallets 73.30% <ø> (ø)
viem-sdks 95.08% <ø> (ø)

@nicolasbrugneaux nicolasbrugneaux marked this pull request as ready for review January 17, 2025 16:09
@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner January 17, 2025 16:09
@nicolasbrugneaux nicolasbrugneaux force-pushed the nicolasbrugneaux/use-safe branch from d39f08c to 1e1adae Compare January 17, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand --useSafe to more commands
2 participants