-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add useSafe for governance:propose and governance:withdraw #511
base: master
Are you sure you want to change the base?
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
- Coverage 76.31% 76.17% -0.14%
==========================================
Files 246 246
Lines 10386 10410 +24
Branches 1639 1651 +12
==========================================
+ Hits 7926 7930 +4
- Misses 2373 2374 +1
- Partials 87 106 +19
|
d39f08c
to
1e1adae
Compare
PR-Codex overview
This PR enhances the governance commands in the CLI by adding support for a new
useSafe
flag, which allows transactions to be executed through SAFE. It also improves documentation and adds checks for safe ownership in governance-related commands.Detailed summary
--useSafe
flag description ingovernance/approve.ts
and documentation.useSafe
andsafeAddress
flags toSafeFlags
inflags.ts
.safeTransactionMetadataFromCeloTransactionObject
function to accept avalue
parameter.useSafe
checks inWithdraw
andPropose
commands.withdraw-l2.test.ts
andpropose-l2.test.ts
.multisigUtils.ts
.