Fix bug for edge case: locking 0 CELO (#148)

celo-org · Mar 2, 2021 · 2129a39 · 2129a39
1 parent e05593d
commit 2129a39
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/analyzer/txtracer.go b/analyzer/txtracer.go
@@ -281,8 +281,11 @@ func (tr *Tracer) TxOpsFromLogs(tx *types.Transaction, receipt *types.Receipt, t
 			case "GoldLocked":
 				// lock() [GoldLocked + transfer] => main->lockNonVoting
 				event := eventRaw.(*contracts.LockedGoldGoldLocked)
-				transfers = append(transfers, *NewLockGold(event.Account, lockedGoldAddr, event.Value))
-
+				// Edge case: locking 0 CELO means there isn't a matching transfer;
+				// Only store balance-changing (>0) GoldLocked logs.
+				if event.Value.Cmp(big.NewInt(0)) > 0 {
+					transfers = append(transfers, *NewLockGold(event.Account, lockedGoldAddr, event.Value))
+				}
 			case "GoldRelocked":
 				// relock() [GoldRelocked] => lockPending->lockNonVoting
 				event := eventRaw.(*contracts.LockedGoldGoldRelocked)