reorganize workspaces into packages and apps #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove phone-number-privacy namespsace from docker files directory
🦋 Changeset detectedLatest commit: bc14e5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…uild next install it does not replace the step
…o build. maybe this means some dev deps should actually be prod deps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganizes workspaces structure to packages, and apps. rather than remanent structure from old celo-monorepo. this makes it easy to see what is a released package vs a deployed application
packages/phone-number-privacy/common => packages/common
packages/sdk/identity => packages/identity
packages/sdk/encrypted-backup => packages/encrypted-backup
packages/phone-number-privacy/signer => apps/signer
packages/phone-number-privacy/combiner => apps/combiner
packages/phone-number-privacy/monitor => apps/monitor
Other changes
moved docker files from dockerfiles/phone-number-privacy => dockerfiles (no sub directory)
Tested
locally ran build and test and waiting on ci
Related issues
Backwards compatibility
internal changes only
Documentation
internal changes only