fix test identifier backwards compatibility test #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be7cec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @celo/[email protected], @celo/[email protected], @celo/[email protected], @celo/[email protected] |
aaronmgdr
reviewed
Jan 5, 2024
packages/identity/src/odis/identifier-backwards-compatibility.test.ts
Outdated
Show resolved
Hide resolved
1 task
Mitigates a false socketdev alert that `@celo/identity` uses a malicious package called `old-identity-sdk`.
soloseng
reviewed
Jan 5, 2024
packages/identity/src/odis/identifier-backwards-compatibility.test.ts
Outdated
Show resolved
Hide resolved
soloseng
approved these changes
Jan 5, 2024
…test.ts Co-authored-by: soloseng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes identifier backwards compatibility test. Test had broken import statement and API compatibilities.
Because all versions of the @celo/identity sdk prior to 5.1.0 are deprecated, and because we know that identifiers had continuity between this version and all previous versions, this PR bumps the "old" sdk version up to 5.1.0
Other changes
NA
Tested
Yes
Related issues
NA
Backwards compatibility
Yes
Documentation
NA