-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition ODIS to cloud function Gen 2 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update packages * change format to number
…norepo into alecps/odisRelease3.0.0
Refactors Signer to be more performant
….0.0 # Conflicts: # packages/phone-number-privacy/combiner/package.json # packages/phone-number-privacy/combiner/src/index.ts # packages/phone-number-privacy/common/README.md # packages/phone-number-privacy/common/src/utils/authentication.ts # packages/phone-number-privacy/monitor/src/query.ts # packages/phone-number-privacy/monitor/src/scripts/run-load-test.ts # packages/phone-number-privacy/monitor/src/test.ts # packages/phone-number-privacy/signer/src/common/controller.ts # packages/phone-number-privacy/signer/src/common/io.ts # packages/phone-number-privacy/signer/src/pnp/endpoints/quota/io.ts # packages/phone-number-privacy/signer/src/pnp/endpoints/sign/action.ts # packages/phone-number-privacy/signer/src/pnp/endpoints/sign/io.ts # packages/phone-number-privacy/signer/src/server.ts # yarn.lock
Adds tracing to the combiner
add mock signer interfaces
* first pass into transforming into handlers * Extract methods out of IO class (story: IO class destruction) * io: getSignerEndpoint lifted up to base class * Remove inputChecks and authenticate from IO * wip: kill Combiner and Signer actions * use handler function (remove IO and Action) * kill ThresholdService and ResponseLogger classes * Removes Session and CryptoSession * Fix typing errors * fix tests * Uses httpAgent for http/s connections * use shouldCheckKeyVerion boolean argument * fix some tests * cosmetic cleanup from PR review * Fixes some tests * fix error reporting * fix pnp integration test * bump combiner version * fix integrations test --------- Co-authored-by: alecps <[email protected]>
alecps
reviewed
Oct 11, 2023
alecps
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @types/[email protected], @types/[email protected], [email protected], [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated to use firebase cloud function gen2
Added a LRU Cache to the combiner to keep a cache of the issuers DEK used to authenticate. This avoids a mandatory call to fullnode to get the DEK.
Related issues
Fixes celo-org/celo-monorepo#10498
Fixes celo-org/celo-monorepo#10499
Fixes #45