Azure wants ExceptionDetail.outerId to be an int #1205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
requested review from
a team,
aabmass,
hectorhdzg,
jeremydvoss and
lzchen
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mgedmin
commented
May 31, 2023
contrib/opencensus-ext-azure/opencensus/ext/azure/trace_exporter/__init__.py
Outdated
Show resolved
Hide resolved
Also, it's supposed to refer to an element in the same ExceptionDetails, in order to represent exception nesting. There's no nesting here, we've a list with a single element. Fixes census-instrumentation#1201.
mgedmin
force-pushed
the
fix-azure-outer-id-type-error
branch
from
ea40d8a
to
d3d8c87
Compare
|
I think the code changes in this PR are too trivial and therefore not copyrightable, but IANAL and dealing with contributor license agreements is not something I have mental headspace right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1201.