Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out Python 2.7 to use custom image #1222

Merged
merged 10 commits into from
Sep 15, 2023

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Sep 14, 2023

Due to Python 2.7 being dropped from github actions images, separate out the python 2.7 build to use a custom image.

Note: This will probably be a temporary measure until we decide to fully drop python 2.7 from opencensus.

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a separate tox file, i didn't understand. It should be OK to leave it exactly as it was right?

@lzchen
Copy link
Contributor Author

lzchen commented Sep 15, 2023

@aabmass

Yeah I was just trying stuff out. I've removed the extra tox file.

tox.ini Outdated Show resolved Hide resolved
@lzchen lzchen merged commit b70b123 into census-instrumentation:master Sep 15, 2023
7 checks passed
@lzchen lzchen deleted the drop branch September 15, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants