Fix build errors #362
Merged
Fix build errors #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liyanhui1228 do we want to revisit the names? I'm open for discussion on what's the best naming. |
reyang
commented
Oct 25, 2018
| @@ -19,7 +19,7 @@ | |||
| from opencensus.trace.trace_options import TraceOptions | |||
|
|
|||
| _TRACE_CONTEXT_HEADER_NAME = 'X-Cloud-Trace-Context' | |||
| _TRACE_CONTEXT_HEADER_FORMAT = '([0-9a-f]{32})(\/([0-9a-f]{16}))?(;o=(\d+))?' | |||
| _TRACE_CONTEXT_HEADER_FORMAT = r'([0-9a-f]{32})(\/([0-9a-f]{16}))?(;o=(\d+))?' | |||
There was a problem hiding this comment.
This is a separate issue which was caught by the latest pylint.
The string literal used for regular expression was not properly escaped.
c24t
approved these changes
Oct 26, 2018
Closed
c24t
pushed a commit
to c24t/opencensus-python
that referenced
this pull request
Nov 21, 2018
* avoid using keyword in package names * fix build error
c24t
pushed a commit
to c24t/opencensus-python
that referenced
this pull request
Nov 21, 2018
* avoid using keyword in package names * fix build error
c24t
pushed a commit
that referenced
this pull request
Nov 28, 2018
* avoid using keyword in package names * fix build error
Closed
|
I'm not a fan of |
Me too! Let's see if we can get rid of it in #642. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting build errors which seems to be related to the recent py3.6 upgrade in CI:
opencensus/stats/exporters/stackdriver_exporter.py:23:42: W606 'async' and 'await' are reserved keywords starting with Python 3.7
opencensus/stats/exporters/stackdriver_exporter.py:112:28: W606 'async' and 'await' are reserved keywords starting with Python 3.7
opencensus/stats/exporters/stackdriver_exporter.py:450:5: F841 local variable 'exception' is assigned to but never used
opencensus/trace/propagation/google_cloud_format.py:22:17: W605 invalid escape sequence '/'
opencensus/trace/propagation/google_cloud_format.py:22:40: W605 invalid escape sequence '\d'
async is becoming a keyword in python3.7, this blocks the current CI (which is using the latest py3.6, and failed due to warnings).