Set default project when on GCP (#526)

census-instrumentation · Apr 16, 2019 · 73558e6 · 73558e6
1 parent eef0179
commit 73558e6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -165,7 +165,7 @@ exporters:
     topic: "opencensus-spans"
 
   stackdriver:
-    project: "your-project-id"
+    project: "my-project-id" # optional, defaults to agent project if run on GCP
     enable_tracing: true
 
   zipkin:

diff --git a/cmd/ocagent/config.yaml b/cmd/ocagent/config.yaml
@@ -7,7 +7,7 @@ receivers:
 
 exporters:
     stackdriver:
-        project: "project-id"
+        project: "project-id" # Optional if on GCP, defaults to agent project
         enable_tracing: true
 
     zipkin:

diff --git a/exporter/stackdriverexporter/stackdriver.go b/exporter/stackdriverexporter/stackdriver.go
@@ -62,12 +62,12 @@ func StackdriverTraceExportersFromViper(v *viper.Viper) (tps []consumer.TraceCon
 
 	// TODO:  For each ProjectID, create a different exporter
 	// or at least a unique Stackdriver client per ProjectID.
-	if sc.ProjectID == "" {
-		return nil, nil, nil, fmt.Errorf("Stackdriver config requires a project ID")
-	}
 
 	sde, serr := stackdriver.NewExporter(stackdriver.Options{
-		ProjectID:    sc.ProjectID,
+		// If the project ID is an empty string, it will be set by default based on
+		// the project this is running on in GCP.
+		ProjectID: sc.ProjectID,
+
 		MetricPrefix: sc.MetricPrefix,
 
 		// Stackdriver Metrics mandates a minimum of 60 seconds for