This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Follow golang/wiki recommendation for tool dependencies and reduce in…
…stall tools set (#578) * Reduce `install-tools` Keeping only go get golang.org/x/lint/golint * Follow golang/wiki recommendation for tool dependencies This ensures that everyone is using the same version of golint, we will have to manually update it when appropriate. * Exclude tools/ from sources to avoid error msg
- Loading branch information
Paulo Janotti
authored
Jun 14, 2019
1 parent
3f272ca
commit bf83eb9
Showing
4 changed files
with
30 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| # More exclusions can be added similar with: -not -path './vendor/*' | ||
| ALL_SRC := $(shell find . -name '*.go' \ | ||
| -not -path './vendor/*' \ | ||
| -not -path './tools/*' \ | ||
| -type f | sort) | ||
|
|
||
| # ALL_PKGS is used with 'go cover' | ||
|
|
@@ -78,11 +79,7 @@ vet: | |
|
|
||
| .PHONY: install-tools | ||
| install-tools: | ||
| go get -u golang.org/x/lint/golint | ||
| go get -u github.com/google/go-cmp/cmp | ||
| go get contrib.go.opencensus.io/exporter/[email protected] | ||
| go get contrib.go.opencensus.io/exporter/prometheus | ||
| go get contrib.go.opencensus.io/exporter/zipkin | ||
| go install golang.org/x/lint/golint | ||
|
|
||
| .PHONY: agent | ||
| agent: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright 2019, OpenCensus Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| // +build tools | ||
|
|
||
| // Package tools follows the recommendation at | ||
| // https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module | ||
| // on how to add tooling dependencies. | ||
| package tools | ||
|
|
||
| import ( | ||
| _ "golang.org/x/lint/golint" | ||
| ) |