-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time I would probably split the pr into multiple.
CI:
- It might be a good idea to make a makefile to unify CI across both local and CI
I would like to know more about how it selects models. - Mixing the APIs with HF models is also a bit confusing. I would split it up.
You are also hiding a lot of complexity from the user, it might be worth letting people know what is going on below the hood.
tests/test_all.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename test_trooper.py
Changed the API completely to make the library more comfortable to use.
Main changes:
Trooper
The brand new
Trooper
interface allows you not to have to specify what model type you wish to use.Stormtrooper will automatically detect the model type from the specified name.
Unified zero and few-shot classification
You no longer have to specify whether a model should be a few or a zero-shot classifier when initialising it.
If you do not pass any training examples, it will be automatically assumed that the model should be zero-shot.
Reimplemented SetFit
The SetFit library caused me many headaches, and has unfixed bugs, and I didn't want to downgrade everything.
I implemented the SetFit algorithm from scratch using training utilities in sentence-transformers.
New docs in MKDocs
Switched ti MKDocs, because it's simpler to deal with and looks better.
Test suite
Added tests to ensure that the library will not break overnight.
Multiple GPU support
Run models on multiple GPU's by passing:
Trooper(model_name, device_map="auto")