Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(storage::netapp::ontap::restapi::plugin) - Mode(volumes,cluster,aggregates,hardware) : Issue on metric.* field not included + fix hardware API requests #5395

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Fix(storage::netapp::ontap::restapi::plugin) - Mode(volumes,cluster,aggregates,hardware) : Issue on metric.* field not included + fix hardware API requests #5395

merged 6 commits into from
Feb 20, 2025

Conversation

itoussies
Copy link
Contributor

@itoussies itoussies commented Jan 16, 2025 •
edited
Loading

Refs: CTOR-783

Centreon team (internal PR)

Description

  • Fix the shelves hardware API request by replacing bay by bays
  • Enhance test API results to include missing metrics

Fixes # (issue)

#5432

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

@itoussies
fix(netapp-ontap-restapi): fix api request
6147bfc 
Fix hardware API request by replacing bay by bays

Refs: CTOR-783
@itoussies
test(netapp-ontap-restapi): update tests
f054489 
Update tests to retrieve all missing metrics

Refs: CTOR-783
@itoussies itoussies requested review from a team as code owners January 16, 2025 10:05
@itoussies
fix(netapp-ontap-restapi): fix api request
22b8bf6 
Fix hardware API request by replacing bay by bays
for the shelves endpoint

Refs: CTOR-783
sdepassio
sdepassio previously approved these changes Jan 20, 2025
View reviewed changes
@lucie-dubrunfaut lucie-dubrunfaut mentioned this pull request Feb 17, 2025
Open
@lucie-dubrunfaut
Copy link
Contributor

@itoussies I added the endpoint fix at the line 71 also

@lucie-dubrunfaut lucie-dubrunfaut mentioned this pull request Feb 17, 2025
Closed
6 tasks
@itoussies
Copy link
Contributor Author

itoussies commented Feb 17, 2025 •
edited
Loading

@lucie-dubrunfaut It's bay for the storage/disks endpoint but bays for the storage/shelves one. The storage/disks endpoint returns the bay where is located the disk whereas the storage/shelves returns the differents bays

@lucie-dubrunfaut
Copy link
Contributor

@itoussies ok my bad I've reverse my change.

@omercier omercier merged commit 0d10876 into develop Feb 20, 2025
30 checks passed
@omercier omercier deleted the CTOR-783 branch February 20, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucie-dubrunfaut lucie-dubrunfaut lucie-dubrunfaut left review comments

@omercier omercier omercier approved these changes

@bouda1 bouda1 Awaiting requested review from bouda1 bouda1 is a code owner automatically assigned from centreon/owners-robot-e2e

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-robot-e2e

@sdepassio sdepassio Awaiting requested review from sdepassio

Assignees
No one assigned
Labels
skip-workflow-plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itoussies @lucie-dubrunfaut @omercier @sdepassio