Add support for additinal service labels #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the helm-chart in conjunction with Spring-Cloud-Kubernetes. Furthermore, we use Spring-Cloud-Open-Feign to publish messages to Centrifugo. Spring uses a DiscoveryClient for Kubernetes which tells Feign where the request should be routed to. As Centrifugo - by default - uses a single service with many ports, Spring does not know to which port the request should be sent. However, Spring allows to add a Label to a Service whose value should be the service port Feign will use: See the Spring docs for
primary-port-name
. With this change, it's possible to addto the
values
yaml, making the Feign client work.