Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additinal service labels #71

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

HJK181
Copy link
Contributor

@HJK181 HJK181 commented Sep 7, 2023

We use the helm-chart in conjunction with Spring-Cloud-Kubernetes. Furthermore, we use Spring-Cloud-Open-Feign to publish messages to Centrifugo. Spring uses a DiscoveryClient for Kubernetes which tells Feign where the request should be routed to. As Centrifugo - by default - uses a single service with many ports, Spring does not know to which port the request should be sent. However, Spring allows to add a Label to a Service whose value should be the service port Feign will use: See the Spring docs for primary-port-name. With this change, it's possible to add

service:
  labels: 
    primary-port-name: "internal"

to the values yaml, making the Feign client work.

@FZambia
Copy link
Member

FZambia commented Sep 7, 2023

Thanks! Please also bump

to 11.0.5

This is required by CI for releasing.

@HJK181
Copy link
Contributor Author

HJK181 commented Sep 7, 2023

Thanks! Please also bump

to 11.0.5

This is required by CI for releasing.

done

@FZambia FZambia merged commit 766f7b1 into centrifugal:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants