Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/release v0.11.0/v2 #1882

Closed
wants to merge 4 commits into from
Closed

Fix/release v0.11.0/v2 #1882

wants to merge 4 commits into from

Conversation

mustermeiszer
Copy link
Collaborator

Description

Replaces #1881.

Changes and Descriptions

  • Use only WasmExecutor everywhere
  • Switch to use MaxEncodedLen instead of mem::size_of

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 46.78%. Comparing base (f750138) to head (a2adb47).

Files Patch % Lines
node/src/command.rs 0.00% 27 Missing ⚠️
node/src/service/evm.rs 0.00% 5 Missing ⚠️
pallets/oracle-feed/src/lib.rs 0.00% 5 Missing ⚠️
node/src/service.rs 0.00% 4 Missing ⚠️
runtime/altair/src/lib.rs 0.00% 1 Missing ⚠️
runtime/centrifuge/src/lib.rs 0.00% 1 Missing ⚠️
runtime/development/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
+ Coverage   46.74%   46.78%   +0.03%     
==========================================
  Files         169      169              
  Lines       13176    13165      -11     
==========================================
  Hits         6159     6159              
+ Misses       7017     7006      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustermeiszer mustermeiszer disabled auto-merge June 21, 2024 15:36
@mustermeiszer
Copy link
Collaborator Author

Please wait with merging till we have sorted out the runtime version increment we wanna do here.

pub const fn size_of_feed<T: Config>() -> u32 {
sp_std::mem::size_of::<(T::OracleKey, T::OracleValue, MomentOf<T>)>() as u32
pub fn size_of_feed<T: Config>() -> u32 {
let max_len = <(T::OracleKey, T::OracleValue, MomentOf<T>)>::max_encoded_len();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@wischli wischli added the I9-release A specific release. label Jun 24, 2024
@wischli wischli mentioned this pull request Jun 24, 2024
4 tasks
@mustermeiszer
Copy link
Collaborator Author

Closing in favor of #1886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I9-release A specific release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants