Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forwarder and use dynamic target in router #151

Closed
wants to merge 0 commits into from

Conversation

mustermeiszer
Copy link
Contributor

No description provided.

@mustermeiszer
Copy link
Contributor Author

Failing test also happens on main, I think the fix is on https://github.com/centrifuge/liquidity-pools/tree/moonbeam-deployment. Will try to get that in.

Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small suggestion ✨

script/Axelar.s.sol Outdated Show resolved Hide resolved
script/Axelar.s.sol Outdated Show resolved Hide resolved
src/gateway/routers/axelar/Forwarder.sol Outdated Show resolved Hide resolved
src/gateway/routers/axelar/Forwarder.sol Outdated Show resolved Hide resolved
src/gateway/routers/axelar/Forwarder.sol Outdated Show resolved Hide resolved
Copy link

Coverage after merging feat/forwarder into main will be

80.87%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Escrow.sol100%100%100%100%
   InvestmentManager.sol91.44%70.97%97.22%98.11%145, 149, 154, 185, 189, 194, 234, 260, 310, 341, 417, 423–424, 454, 490–491, 534, 536, 580, 639–640
   LiquidityPool.sol95.24%80%97.44%98.51%101, 112, 128–129, 164
   PoolManager.sol95.87%87.14%100%100%175, 191, 217, 228, 307, 315, 327, 332, 358
   Root.sol100%100%100%100%
   UserEscrow.sol100%100%100%100%
src/admins
   DelayedAdmin.sol100%100%100%100%
   PauseAdmin.sol100%100%100%100%
src/gateway
   Gateway.sol94.59%83.33%100%98.88%329, 341, 353, 366, 379, 382, 398, 405
   Messages.sol62.77%16.67%60.47%65.38%105, 124, 153, 194, 202, 237, 282–285, 381, 389–393, 417, 425, 449, 457, 481, 489, 509, 517–520, 540, 548–551, 562, 605, 649, 696, 735, 747, 773, 810–813, 829–832, 843, 86, 869, 892, 922, 953–954, 956–957, 957, 957–958, 960, 964, 968, 985–986, 986, 986–987, 991
src/gateway/routers/axelar
   Forwarder.sol0%0%0%0%46, 46, 46–47, 49, 52, 62, 62, 62, 67–68, 70, 81
   LocalGateway.sol0%100%0%0%25, 27
   Router.sol100%100%100%100%
src/gateway/routers/xcm
   Router.sol0%0%0%0%103, 103, 103–104, 106, 109, 114, 119, 121, 123, 142, 157, 157, 157–159, 159, 159, 161–162, 162, 162–164, 164, 164–166, 166, 166–168, 168, 168–170, 170, 170–172, 172, 172–173, 175, 182–183, 185, 189–191, 193, 197, 90, 90, 90–91, 93, 96
src/token
   ERC20.sol95.42%92.86%92.86%97.33%199, 228, 67, 85–86
   RestrictionManager.sol93.33%87.50%100%95.65%71–72, 96
   Tranche.sol91.18%100%75%100%
src/util
   Auth.sol100%100%100%100%
   BytesLib.sol12.07%0%12.50%17.65%10, 10, 10, 102, 102, 102–103, 106, 109, 11, 11, 11, 113, 113, 113–114, 117, 120, 124, 124, 124–125, 128, 13, 131, 65, 69, 69, 69–70, 73, 76, 80, 80, 80–81, 84, 87, 91, 91, 91–92, 95, 98
   Factory.sol100%100%100%100%
   MathLib.sol0%0%0%0%105–106, 106, 106–107, 109, 114, 114, 114–115, 117, 24–25, 28–29, 33, 33, 33, 37, 41, 41, 41, 48, 51, 54–55, 63, 66, 69, 72, 76, 81, 86–91, 97–98
   SafeTransferLib.sol87.50%66.67%100%100%28, 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants