Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: stop using dh_python2 ${python:Depends} #529

Open
wants to merge 1 commit into
base: 1.3
Choose a base branch
from

Conversation

ktdreyer
Copy link
Member

@ktdreyer ktdreyer commented Mar 6, 2018

When dh_python2 parses the requires.txt files in Calamari and
Calamari's bundled libraries, it translates the dependencies listed
there into "python-" packages and adds them into ${python:Depends}.

In the past this has led to the calamari-server .deb depending on system
packages that do not exist, which leads to installation failures.

Since ${python:Depends} doesn't work well with Calamari's method of
bundling libraries in a virtualenv, just remove it and hard-code the
list of python Depends in /debian/control.

(I've just copied & pasted the existing list that dh_python2 was already
picking up, so maybe this Depends list could be trimmed further, with
experimentation.)

(cherry picked from commit a47b3ff)

Conflicts:
debian/control
Resolved by using the list from dpkg -I from the current build on
this branch.

When dh_python2 parses the `requires.txt` files in Calamari and
Calamari's bundled libraries, it translates the dependencies listed
there into "python-" packages and adds them into ${python:Depends}.

In the past this has led to the calamari-server .deb depending on system
packages that do not exist, which leads to installation failures.

Since ${python:Depends} doesn't work well with Calamari's method of
bundling libraries in a virtualenv, just remove it and hard-code the
list of python Depends in /debian/control.

(I've just copied & pasted the existing list that dh_python2 was already
picking up, so maybe this Depends list could be trimmed further, with
experimentation.)

(cherry picked from commit a47b3ff)

 Conflicts:
	debian/control
	  Resolved by using the list from `dpkg -I` from the current build on
          this branch.
@ktdreyer
Copy link
Member Author

ktdreyer commented Mar 6, 2018

(FYI I've cherry-picked this to the downstream packaging branch already; this is just to get it upstreamed too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant