Skip to content

Commit

Permalink
ceph-volume: add support check mode
Browse files Browse the repository at this point in the history
Run read-only actions on check mode

Signed-off-by: Seena Fallah <[email protected]>
  • Loading branch information
clwluvw authored and guits committed Mar 15, 2024
1 parent 49ec247 commit b60e013
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion library/ceph_volume.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,23 @@ def zap_devices(module, container_image):
return cmd


def allowed_in_check_mode(module):
'''
Check if the action is allowed in check mode
'''

action = module.params['action']
report = module.params.get('report', False)

# batch is allowed in check mode if report is set
if action == 'batch' and report:
return True

allowed_actions = ['list', 'inventory']

return action in allowed_actions


def run_module():
module_args = dict(
cluster=dict(type='str', required=False, default='ceph'),
Expand Down Expand Up @@ -524,7 +541,7 @@ def run_module():
delta='',
)

if module.check_mode:
if module.check_mode and not allowed_in_check_mode(module):
module.exit_json(**result)

# start execution
Expand Down

0 comments on commit b60e013

Please sign in to comment.