radosgw_zonegroup: support check mode (backport #7506) #7514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The returned payload from rgw has is_master as a boolean. By having master as a string it would always report a change and try to modify the zonegroup. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit e8d34b6)
Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit beb046c)
clwluvw
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned payload from rgw has
is_masteras a boolean. By havingmasteras a string it would always report a change and try to modify the zonegroup.This is an automatic backport of pull request #7506 done by Mergify.