-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: resturcture the doc folder #4907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to move the mount corruption doc to design and same for cephfs snapshot backed volumes as well and for rbd-nbd as well.
we can have a deploy folder for deployments instead of having separate folder in the doc itself.
@Nikhil-Ladha @Rakshith-R any thoughts?
While moving the file into new directories per component, you can remove the redundant component name in the filename. For example: docs/deploy-rbd.md → docs/rbd/deploy.md |
I agree if you mean moving the files like this: docs/deploy-rbd.md → deploy/rbd.md Possibly add a symlink like docs/rbd/deploy.md pointing to the deploy/rbd.md file. |
Moving to deploy folder and having symlink sounds good! |
sounds good to me |
1e542e0
to
1603482
Compare
deploy/rbd/deploy.md
Outdated
@@ -0,0 +1 @@ | |||
docs/rbd/deploy.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessing symlink failed for me, can you please cross check this and see if you are able to access the file if you open it from deploy folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, shows error while opening, will check on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works now, please do review it again
1603482
to
c5b5707
Compare
\retest |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
c5b5707
to
35cffb9
Compare
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a6f1af4 |
This commit is the restructure the doc folder to include sub-folders like csi-addons, rbd, cephfs to contain related docs and other general docs can be placed under doc folder. This will enhance the doc structure will make it easier for the users to search the docs as it get more populated. Signed-off-by: yati1998 <[email protected]>
35cffb9
to
e618f31
Compare
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.30 |
/test ci/centos/k8s-e2e-external-storage/1.29 |
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/mini-e2e-helm/k8s-1.29 |
/test ci/centos/k8s-e2e-external-storage/1.31 |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/mini-e2e-helm/k8s-1.31 |
/test ci/centos/mini-e2e/k8s-1.29 |
/test ci/centos/mini-e2e/k8s-1.31 |
This commit is the restructure the doc folder to
include sub-folders like csi-addons, rbd, cephfs
to contain related docs and other general docs can be placed under doc folder.
This will enhance the doc structure will make it easier for the users to search the docs as it get more populated.