Restructure (split gRPC and server code, better naming, Makefile) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PepperJo
suggested changes
Aug 3, 2022
trociny
reviewed
Aug 4, 2022
PepperJo
suggested changes
Aug 16, 2022
trociny
reviewed
Aug 16, 2022
oritwas
reviewed
Sep 1, 2022
oritwas
reviewed
Sep 1, 2022
idryomov
reviewed
Sep 6, 2022
This commit reorganizes and renames files. It also adds a Makefile to simplify protobuf compilation and use of other basic commands like starting the server. Signed-off-by: Sandy Kaur <[email protected]>
This commit splits gRPC API away from server code that handles SPDK startup and monitoring. Signed-off-by: Sandy Kaur <[email protected]>
Signed-off-by: Sandy Kaur <[email protected]>
Signed-off-by: Sandy Kaur <[email protected]>
Signed-off-by: Sandy Kaur <[email protected]>
idryomov
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits reorganize existing code but do not attempt to add any functionality.
@idryomov