Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "mg_get_local_addr". Return the local listening address used. #15

Open
wants to merge 1 commit into
base: wip-civetweb-1.8
Choose a base branch
from

Conversation

mdw-at-linuxbox
Copy link

civetweb can listen to multiple addresses. Some of these can have
ssl enabled, and some not. The "using_ssl" flag is
already returned to the client, but the local address (lsa) is not,
This allows a calling application to determine on which local
address/portno a connection was accepted.

Signed-off-by: Marcus Watts [email protected]

civetweb can listen to multiple addresses.  Some of these can have
ssl enabled, and some not.  The "using_ssl" flag is
already returned to the client, but the local address (lsa) is not,
This allows a calling application to determine on which local
address/portno a connection was accepted.

Signed-off-by: Marcus Watts <[email protected]>
@ktdreyer
Copy link
Member

ktdreyer commented Jan 4, 2017

Will this go into civetweb upstream?

@mdw-at-linuxbox
Copy link
Author

I structured most of the work I did to civetweb with an eye towards making it palatable upstream. But I haven't talked to upstream so don't know how hard it actually would be to get any of our civetweb changes upstream.

@mikulely
Copy link

mikulely commented Jan 16, 2017

@mdw-at-linuxbox Would you plz merge this first and update civetweb submodule? or remove invokation of
mg_get_local_addr ? This broken master(d644f911e6acfd75f79a44cd73e6b3b9c042ad15) build:

running build
running build_ext
[ 99%] Built target cython_rbd
running build
running build_ext
[ 99%] Built target cython_rgw
[ 99%] Built target cython_modules
/home/mikulely/ceph/src/rgw/rgw_civetweb.cc: In constructor ‘RGWCivetWeb::RGWCivetWeb(mg_connection*)’:
/home/mikulely/ceph/src/rgw/rgw_civetweb.cc:38:43: error: ‘mg_get_local_addr’ was not declared in this scope
     sockaddr *lsa = mg_get_local_addr(conn);
                                           ^
make[2]: *** [src/rgw/CMakeFiles/radosgw_a.dir/rgw_civetweb.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/rgw/CMakeFiles/radosgw_a.dir/all] Error 2
make: *** [all] Error 2

Thx.

@cbodley
Copy link

cbodley commented Feb 13, 2018

@mdw-at-linuxbox it looks like we're still maintaining this in our fork - has this been proposed upstream?

@boboliliy
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants