Library KPIs: items in the institutional repo #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestaP
force-pushed
the
library-inspire-kpi
branch
from
4d8c5ec to
9a0f74c
Compare
ErnestaP
changed the title
drjova
requested changes
Jul 29, 2024
|
|
||
| results = join_and_add_year(counts) | ||
|
|
||
| populate_items_in_the_institutional_repository = PostgresOperator( |
There was a problem hiding this comment.
I really like the approach of Postgres Operator although I feel reluctant about raw SQL operations. With a quick search I found that it's possible to use SQLAlchemy for this kind of operations https://sorokin.engineer/posts/en/apache_airflow_sqlalchemy_operator.html. Can we give it a try?
There was a problem hiding this comment.
@ErnestaP only this is missing to investigate, thank you
dags/migrations/versions/101f23913167_library_kpis_new_items_in_the_.py
Outdated
Show resolved
Hide resolved
drjova
reviewed
Jul 29, 2024
ErnestaP
force-pushed
the
library-inspire-kpi
branch
2 times, most recently
from
a7260ec to
eaf68ac
Compare
drjova
reviewed
Jul 31, 2024
| @sqlalchemy_task(conn_id="superset_qa") | ||
| def populate_golden_open_access(results, session, **kwargs): | ||
| record = ( | ||
| session.query(OAGoldenOpenAccess).filter_by(year=results["year"]).first() |
There was a problem hiding this comment.
this will fail if there is None, we have to do first_or_none()
drjova
reviewed
Jul 31, 2024
| ) | ||
| @sqlalchemy_task(conn_id="superset_qa") | ||
| def populate_open_access(results, session, **kwargs): | ||
| record = session.query(OAOpenAccess).filter_by(year=results["year"]).first() |
drjova
requested changes
Jul 31, 2024
|
|
||
|
|
||
| class LibraryNewItemsInTheInstitutionalRepository(Base): | ||
| __tablename__ = "items_in_the_institutional_repository" |
There was a problem hiding this comment.
Suggested change
| __tablename__ = "items_in_the_institutional_repository" | |
| __tablename__ = "library_items_in_the_institutional_repository" |
| record = ( | ||
| session.query(LibraryCernPublicationRecords) | ||
| .filter_by(year=results["year"]) | ||
| .first() |
ErnestaP
force-pushed
the
library-inspire-kpi
branch
from
eaf68ac to
233cc14
Compare
drjova
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.