Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add curation actions #483

Closed
drjova opened this issue Jun 14, 2024 · 4 comments · Fixed by inspirehep/backoffice#60
Closed

add curation actions #483

drjova opened this issue Jun 14, 2024 · 4 comments · Fixed by inspirehep/backoffice#60

Comments

@drjova
Copy link
Contributor

drjova commented Jun 14, 2024

Configure curation actions from backoffice, the curators/admins, should be able to do the following actions:

  • 'Approve'
  • 'Reject'
  • restart
  • skip to step (by default next)
  • restart current
  • restart with params

We already have the airflow DAGs, we need to have configure the airflow API and document how each one is working.

@DonHaul
Copy link
Collaborator

DonHaul commented Jun 19, 2024

@drjova
This is dependent on:
https://github.com/inspirehep/workflows/pull/2/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9
I have made a few minor changes to the airflow repo so that it can works as intended

@DonHaul
Copy link
Collaborator

DonHaul commented Jun 19, 2024

Another previous step must be implemented which is to trigger workflows in airflow through the backoffice.
An initial version has been implemented in https://github.com/DonHaul/backoffice/tree/submissions .
Needs to be rebased and adapted

@DonHaul
Copy link
Collaborator

DonHaul commented Jul 2, 2024

inspirehep/backoffice#45 first step, it: connects to airflow and triggers dags regarding:

  • author creation
  • author approval
  • author rejection

@DonHaul
Copy link
Collaborator

DonHaul commented Aug 1, 2024

In summary there's 3 new endpoints:

  • POST /api/workflows/authors - to create an author. it replaces the previous /api/workflows, receives the same payload
  • POST /api/workflows/authors/<id>/resolve receives:
{
  "value": "accept",  #or "reject"
  "create_ticket": true # or false
}
  • POST /api/workflows/authors/<id>/restart receives:
{
  "restart_current_task" : true # if not specified defaults to false
  "params" : {dictionary with new params} # this was requested in user action buts its not yet specified what this params are, if not specified, a full restart is done
}

also it can simply have no payload, and in this case a full restart occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants