This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
author-consolidation #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonHaul
force-pushed
the
author-consolidation
branch
from
bf4adc8 to
6016924
Compare
|
Took the opportunity to fix some small issues in the aggreggations and its tests |
DonHaul
force-pushed
the
author-consolidation
branch
from
6016924 to
7bf4015
Compare
drjova
suggested changes
Aug 5, 2024
…n, updated partialupdate but needs testing
DonHaul
force-pushed
the
author-consolidation
branch
from
7bf4015 to
56fd71c
Compare
drjova
suggested changes
Aug 5, 2024
docker-compose.yaml
Outdated
| @@ -61,6 +61,7 @@ x-airflow-common: &airflow-common | |||
| AIRFLOW__CORE__DAGS_ARE_PAUSED_AT_CREATION: "true" | |||
| AIRFLOW__CORE__LOAD_EXAMPLES: "false" | |||
| AIRFLOW__API__AUTH_BACKENDS: "airflow.api.auth.backend.basic_auth,airflow.api.auth.backend.session" | |||
| # AIRFLOW__WEBSERVER__RELOAD_ON_PLUGIN_CHANGE: "true" # used when modifying plugins | |||
There was a problem hiding this comment.
why remove this one? It's useful when you modify plugins
There was a problem hiding this comment.
you are right, although we should add set it to false in our kubernetes as it may cause high memory usage and race conditions:
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#reload-on-plugin-change
There was a problem hiding this comment.
Thanks, we have to update it here actually
DonHaul
force-pushed
the
author-consolidation
branch
4 times, most recently
from
2e74b7d to
a7c1dcd
Compare
DonHaul
force-pushed
the
author-consolidation
branch
from
a7c1dcd to
da9db83
Compare
drjova
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed aggreggations, added swagger documentation, updated partialupdate but needs testing
Fixes 483