Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision action log #518

Closed
Tracked by #513
drjova opened this issue Aug 7, 2024 · 1 comment · Fixed by inspirehep/backoffice#76
Closed
Tracked by #513

Decision action log #518

drjova opened this issue Aug 7, 2024 · 1 comment · Fixed by inspirehep/backoffice#76

Comments

@drjova
Copy link
Contributor

drjova commented Aug 7, 2024

We need to implement logging for curator decisions in the backoffice. When a curator makes a decision on an author submission (either "Accept" or "Reject")

This task is linked with #522, please handle them together

Tech NOTES

Database Schema:

Create a new table named Decision to store the following fields:

  • created_at: DateTime field for when the decision was made.
  • updated_at: DateTime field for when the decision was made.
  • user_id: id field for the curator id
  • workflow_id: uuid for the workflow identifier.
  • action: enum field for the action taken, corresponding to the resolution actions..

Serializer:

Update the workflow serializer to include the Decision data.

Views

{
  "decision": "accept" | "reject" | "accept curate"
}

UI

Display the decision in the UI

NOTES:

  • A Decision table is created and properly integrated into the database schema and run migrations on dev
  • The workflow serializer is updated to include decision details.
  • Curator actions are logged correctly with all required details.
@drjova drjova added this to the new holdingpen milestone Aug 7, 2024
@karolina-siemieniuk-morawska
Copy link
Collaborator

karolina-siemieniuk-morawska commented Aug 9, 2024

TECH NOTES (for UI):

  1. In AuthorDetailPageContainer.tsx when status is completed instead of displaying decision buttons, display decision.
  2. In AuthorResultItem.tsx lines 92-100 adjust the UnclickableTag component to new data structure.

@DonHaul DonHaul assigned DonHaul and unassigned DonHaul Aug 13, 2024
@DonHaul DonHaul linked a pull request Aug 16, 2024 that will close this issue
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 23, 2024
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 23, 2024
backoffice: added decision connecion in serializer

* ref: cern-sis/issues-inspire/issues/518
@drjova drjova closed this as completed Aug 26, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Aug 26, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Aug 26, 2024
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 27, 2024
backoffice: added decision connecion in serializer

* ref: cern-sis/issues-inspire/issues/518
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Sep 2, 2024
backoffice: added decision connecion in serializer

* ref: cern-sis/issues-inspire/issues/518
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Sep 2, 2024
backoffice: added decision connecion in serializer

* ref: cern-sis/issues-inspire/issues/518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment