code(custom tooltip): enabling custom tooltips for relevant field types #90
Conversation
…m tooltip for relevant fieldtypes Signed-off-by: Ansh Sarkar <[email protected]>
|
@pamfilos requesting you to kindly review this PR whenever convenient. Kindly do let me know if there are any changes required. Thank you. |
|
Hi @pamfilos ! Looks like one of the tests is failing. Any suggestions on how to proceed from here ? |
There was a problem hiding this comment.
Hi @Ansh-Sarkar, thanks for your PR and sorry for the very late review. I have left some small comments.
Also, has the commitizen cli popped up when creating your commit? From your commit message it seems like the hook might not have triggered. Your commit message should look like feat(form): ... and be under 100 characters. If you check the commitlint check/test you can see it's failing for these reasons.
| @@ -515,6 +522,7 @@ const simple = { | |||
| { const: "number", title: "Float" }, | |||
| ], | |||
| }, | |||
| tooltip: extra.optionsSchema.tooltip, | |||
There was a problem hiding this comment.
Please move the tooltip up, here and in other fields, so that it appears directly under title and description (i.e. directly after ...common.optionsSchema)
| @@ -640,7 +648,6 @@ const simple = { | |||
| type: { | |||
There was a problem hiding this comment.
Add tooltip support also in switch
|
Also, do you think you can update this test to verify that the tooltip is showing up when set? If you are not familiar with cypress I can take care of it. |
|
Please update commit message with below fixes: |
Yeah sure I'll get this done as well. Am sorry about the late response. Was not keeping well for a while. Am doing better now. Fixing this PR. Thanks! |
Sure. Thanks. |
Fixes: #16 by @pamfilos
Description: Introduces the ability for users to define tooltips for relevant fieldTypes. The solution has been ported from the original repository cernanalysispreservation/analysispreservation.cern.ch (#2800). The enhancement improves the user experience by providing informative tooltips that can be customized for each field, ensuring better clarity and guidance.