oup: fixes bug for orcid parsing

Signed-off-by: pamfilos <[email protected]>
cern-sis · Aug 30, 2024 · 2137343 · 2137343
1 parent c195c61
commit 2137343
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/dags/oup/parser.py b/dags/oup/parser.py
@@ -163,7 +163,7 @@ def _get_authors(self, article):
         )
         authors = []
         for contribution in contributions:
-            orcid = get_text_value(contribution.find("contrib-id"))
+            orcid = get_text_value(contribution.find("contrib-id[@contrib-id-type='orcid']"))
             surname = get_text_value(contribution.find("name/surname"))
             given_names = get_text_value(contribution.find("name/given-names"))
             email = get_text_value(contribution.find("email"))

diff --git a/tests/units/oup/data/oup_orcid.xml b/tests/units/oup/data/oup_orcid.xml
@@ -46,6 +46,7 @@
             </title-group>
             <contrib-group>
                 <contrib contrib-type="author">
+                    <contrib-id contrib-id-type="orc">https://orcid.org/0000-0002-7719-4155</contrib-id>
                     <contrib-id contrib-id-type="orcid">https://orcid.org/0000-0002-7719-4160</contrib-id>
                     <name>
                         <surname>Hong</surname>