Documentation: Hindawi #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestaP
force-pushed
the
hindawi-doc
branch
from
f94b823 to
d572da4
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 110 110
Lines 4859 4859
=======================================
Hits 4493 4493
Misses 366 366 ☔ View full report in Codecov by Sentry. |
drjova
reviewed
Nov 15, 2023
dags/hindawi/parser.py
Outdated
| @@ -133,7 +133,7 @@ def _get_arxiv(self, article: ET.Element): | |||
| self.prefixes, | |||
| ) | |||
| if not arxivs: | |||
| self.logger.error("No arxiv id_get_copyright_statement found.") | |||
| self.logger.error("No arxiv _get_arxiv found.") | |||
There was a problem hiding this comment.
what that means? :) Should it be no arxiv id found?
ErnestaP
force-pushed
the
hindawi-doc
branch
from
dcba851 to
ad46d2a
Compare
ErnestaP
force-pushed
the
hindawi-doc
branch
from
ad46d2a to
f6e4226
Compare
drjova
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.