Elsevier: parse a group affiliation if there is no affid assigned for… #185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 92.49% 92.54% +0.05%
==========================================
Files 110 110
Lines 4821 4828 +7
==========================================
+ Hits 4459 4468 +9
+ Misses 362 360 -2 ☔ View full report in Codecov by Sentry. |
ErnestaP
force-pushed
the
elsevier-group-affiliation
branch
2 times, most recently
from
1a70701 to
47940eb
Compare
|
@ErnestaP instead of changing the code, wouldn't it be enough to filter out the |
|
Just noting what I said this morning: we cannot because the authors should have affiliation parsed differently if there is no affid associated with them. We need to take the whole affiliation group. Leaving the code the same and just clean None values, will leave authors without affiliations. While the affiliations are actually in the metadata, just have to be parsed in another way |
| "journal_artid", | ||
| id="test_journal_artid", | ||
| ), | ||
| ], | ||
| ) | ||
| def test_elsevier_parsing(parsed_articles, expected, key): | ||
| print(parsed_articles[3]["authors"]) |
* If there is no affid assigned for an author, a group affiliation should be assigned for author * ref: cern-sis/issues-scoap3#262
ErnestaP
force-pushed
the
elsevier-group-affiliation
branch
from
3426bf4 to
5ed8539
Compare
No description provided.