Elsevier: publication_info added artid, journal doctype, volume #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestaP
force-pushed
the
journal-info
branch
from
5638790 to
cad8adc
Compare
drjova
reviewed
Dec 11, 2023
dags/common/utils.py
Outdated
| @@ -72,7 +72,7 @@ def parse_to_int(value): | |||
| logger.error("Cannot parse to integer", value=value) | |||
|
|
|||
|
|
|||
| def extract_text(article, path, field_name, dois): | |||
| def extract_text(article, path, field_name, dois="No DOI passed"): | |||
There was a problem hiding this comment.
I think this should be part of the doi extraction, we don't need it for the log
ErnestaP
force-pushed
the
journal-info
branch
from
cad8adc to
b32d7b5
Compare
drjova
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.