feat: warning about folders public links #178
Conversation
rodcoffani
commented
Mar 14, 2025
rodcoffani
commented
- warning (text or modal) triggered when creating an Editor link for a folder
- add a maxDate property on oc-datepicker component
- set default expiration dates for Editor links on folders
| warningMessage.className = 'oc-mb-m oc-p-s oc-background-secondary oc-rounded' | ||
| warningMessage.id = 'files-file-link-warning' | ||
| warningMessage.innerHTML = $gettext( | ||
| 'Anonymously writable folders might be abused to store illicit material. <span class="oc-text-bold">Therefore, the default expiration time has been set to one month.</span> Please consider sharing to specific users or groups if the intended audience has a CERN (primary or external) account.' |
There was a problem hiding this comment.
This is ok, but we should push this upstream, so I would try to improve a little bit more.
That means that the message needs to be configurable (and not hard copied in two different places), in config.json. I would take that as the condition to show the warning message (if config is set, then we show it when adding a folder with editing rights. Otherwise we don't show anything). The message should take into consideration the current used language (check other examples in wich we set different messages depending on the language).
| if (unref(resource).isFolder && options.type === 'edit' && !linkShare.expirationDateTime) { | ||
| Object.assign(options, { | ||
| ...options, | ||
| expirationDateTime: DateTime.now().plus({ days: 30 }).endOf('day').toISO() |
There was a problem hiding this comment.
Please make these things configurable as well (I mean the default and maximum). I would expect to have this in the same place where oC enforces the use of passwords for public links, for example. I'm not sure this comes from config.json, it might be a "capability" (meaning that this is set in the backend and enforced there as well).
- folders expiration date defined in capability store - if the expiration is set for more than the maximum defined, is updated - removes the option to unset expiration dates for RW folders
- only for folders with RW permissions - modal or div, based on if it was created or updated - alert message defined in config store by language - check if message exists before showing
rodcoffani
force-pushed
the
feat/warning-rw-links
branch
from
f09e172 to
0fe0b30
Compare
|
the capability store still needs to be updated in the backend |
chore(deps): update babel monorepo to v7.26.9
| @@ -192,14 +199,52 @@ export default defineComponent({ | |||
| options: UpdateLinkOptions['options'] | |||
| }) => { | |||
| try { | |||
| if (unref(resource).isFolder && options.type === 'edit' && !linkShare.expirationDateTime) { | |||
There was a problem hiding this comment.
if the default value is not set, we should not set it.
| }) | ||
| } | ||
| if (unref(resource).isFolder && linkShare.expirationDateTime) { | ||
| if ( |
There was a problem hiding this comment.
Also here, default expiration might not be set.
| minDate: DateTime.now() | ||
| minDate: DateTime.now(), | ||
| maxDate: | ||
| resource.value.isFolder && props.linkShare.type === SharingLinkType.Edit |
| } | ||
| }) | ||
| // only if is not a edit folder link | ||
| if (!(props.linkShare.type === SharingLinkType.Edit && resource.value.isFolder)) { |
There was a problem hiding this comment.
If expiration is mandatory (i.e. max is defined).
| @@ -48,6 +48,11 @@ | |||
| v-if="isAdvancedMode" | |||
| class="oc-mt-s" | |||
| :min-date="DateTime.now()" | |||
| :max-date=" | |||
| isFolder && selectedType === 'edit' | |||
| @@ -40,7 +42,7 @@ export const useFileActionsCreateLink = ({ | |||
| }: { | |||
| result: PromiseSettledResult<LinkShare>[] | |||
| password?: string | |||
| options?: { copyPassword?: boolean } | |||
| options?: { isRW?: boolean; isFolder?: boolean; copyPassword?: boolean } | |||
There was a problem hiding this comment.
Isn't this info available in result? If at least one is folder and rw, then show the warning.
| hideLogo: false | ||
| hideLogo: false, | ||
| alertRwFolders: { | ||
| en: '', |
