Availability facet #138
Open
Availability facet #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
reviewed
Feb 3, 2025
cernopendata/config.py
Outdated
| ): | ||
| _query = _query & ~dsl.Q("match", **{"distribution.availability": "ondemand"}) | ||
|
|
||
| # if ( |
There was a problem hiding this comment.
I've put it back, since the tests were not happy. If we remove this, we break backward compatibility if a user was searching through this field
| f.delete() | ||
| elif "type" in file and file["type"] == "index.txt": | ||
| # The txt indexes should be ignored. Just delete the file | ||
| f.delete() | ||
| else: | ||
| real_files.append(file) | ||
| try: | ||
| obj = ObjectVersion.create(record.bucket, filename, _file_id=f.id) | ||
| obj = FileObjectCold.create(record.bucket, filename, f.id) |
There was a problem hiding this comment.
Suggested change
| obj = FileObjectCold.create(record.bucket, filename, f.id) | |
| obj = FileObjectCold.create_version(record.bucket, filename, f.id) |
just to separate the creation of a file obj and file object version?
There was a problem hiding this comment.
Ok, thanks! I'll address this on #137 (this PR included two commits, the one of 137 and another one based on that one).
psaiz
commented
Feb 3, 2025
| """Overwrite the fileobject to get multiple URI and availability.""" | ||
|
|
||
| @classmethod | ||
| def create(self, bucket, filename, file_id): |
There was a problem hiding this comment.
Suggested change
| def create(self, bucket, filename, file_id): | |
| def create_version(self, bucket, filename, file_id): |
psaiz
commented
Feb 3, 2025
psaiz
commented
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #118