remove lti_tools.proxy_launch #2965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language
github-actions
bot
added
the
documentation
chrieinv
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the 'proxy launch' setting. With this disabled, Edlib would return a direct URL to the tool (e.g. Content Author) upon insertion, instead of a URL to the Hub, which would only work if the platform and the tool had exchanged keys in advance.
Adding this setting on the tool level was a mistake, but returning direct URLs might be useful in some circumstances. It could be brought back as an instance or LTI platform setting later, but right now there isn't much use for it.