Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update governance docs around code of conduct violations #36

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Update governance docs around code of conduct violations #36

merged 5 commits into from
Sep 12, 2024

Conversation

SgtCoDFish
Copy link
Member

It was recommended in our graduation review (see #35) that we:

...add a process for removing Maintainers (and SC members) for reasons other than inactivity, such as violating the CoC or disruptive behavior.

This commit attempts to codify that removal process.

Most of the legwork for the process is already done in the CNCF foundation repo.

Note that this expands the scope of the steering committee slightly by adding a new requirement, and this PR obviously changes our governance process. As such, this PR will go through a lazy consensus process and steering committee members will be explicitly asked to review.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2024
PT-GD
PT-GD approved these changes Sep 5, 2024
View reviewed changes
Copy link

@PT-GD PT-GD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective as an "external stakeholder" and contributor

erikgb
erikgb reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together this, Ashley! I've added a couple of comments/suggestions.

@SgtCoDFish SgtCoDFish mentioned this pull request Sep 6, 2024
Closed
3 tasks
@FlorianLiebhart
Copy link
Member

👍 Looks good from my side as well! :)

@erikgb
Copy link
Contributor

erikgb commented Sep 6, 2024

/lgtm

@cert-manager-prow
Copy link
Contributor

@erikgb: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SgtCoDFish SgtCoDFish mentioned this pull request Sep 6, 2024
Open
12 tasks
@SgtCoDFish
Copy link
Member Author

All reviews welcome on this! Thank you to everyone who's already reviewed 🚀

Unless there's a blocker, the lazy consensus period for reviewing will expire on 2024-09-12 at 12:00 London time and this will be accepted

PT-GD
PT-GD reviewed Sep 6, 2024
View reviewed changes
munnerz
munnerz reviewed Sep 9, 2024
View reviewed changes
SgtCoDFish referenced this pull request in SgtCoDFish/cert-manager-community Sep 9, 2024
@SgtCoDFish
munnerz comments 1
6b7ad75 
see https://github.com/cert-manager/community/pull/36\#discussion_r1750176679

Signed-off-by: Ashley Davis <[email protected]>
@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2024
SgtCoDFish referenced this pull request in SgtCoDFish/cert-manager-community Sep 9, 2024
@SgtCoDFish
munnerz comments 1
a7a5fe2 
see https://github.com/cert-manager/community/pull/36\#discussion_r1750176679

Signed-off-by: Ashley Davis <[email protected]>
@SgtCoDFish
Copy link
Member Author

Thanks for the review @munnerz - I've made some minor updates which I hope should address your comments!

munnerz
munnerz approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @SgtCoDFish!

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@munnerz
Copy link
Member

munnerz commented Sep 9, 2024

/lgtm
/hold (assuming we are waiting for a quorum before merging.. otherwise feel free to remove the hold!)

@cert-manager-prow cert-manager-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 9, 2024
@SgtCoDFish
Copy link
Member Author

Thanks for the review + hold! I'll wait until lazy consensus ends on 2024-09-12 at 12:00 London time before merging, just to give everyone the best chance to review (there's no rush I don't think!)

SgtCoDFish referenced this pull request in SgtCoDFish/cert-manager-community Sep 9, 2024
@SgtCoDFish
munnerz comments 1
f74805e 
see https://github.com/cert-manager/community/pull/36\#discussion_r1750176679

Signed-off-by: Ashley Davis <[email protected]>
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@SgtCoDFish
update governance docs around code of conduct violations
3e87601 
It was recommended in our graduation review (see cert-manager#35) that we:

> ...add a process for removing Maintainers (and SC members)
> for reasons other than inactivity, such as violating the CoC
> or disruptive behavior.

This commit attempts to codify that removal process.

Most of the legwork for the process is already done in the CNCF
foundation repo:

https://github.com/cncf/foundation/tree/main/code-of-conduct

Signed-off-by: Ashley Davis <[email protected]>
@SgtCoDFish SgtCoDFish mentioned this pull request Sep 10, 2024
Closed
3 tasks
@SgtCoDFish
Copy link
Member Author

(The changes are just me rebasing against the latest commits on main - no text changes)

erikgb
erikgb approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks very nice! Thanks, Ash!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, munnerz, PT-GD, ssyno

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Member Author

/unhold

Lazy consensus has ended and there aren't any blockers so this is accepted and will be merged. Thanks to everyone that participated!

@cert-manager-prow cert-manager-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@cert-manager-prow cert-manager-prow bot merged commit a3f74f7 into cert-manager:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PT-GD PT-GD PT-GD approved these changes

@munnerz munnerz munnerz approved these changes

@erikgb erikgb erikgb approved these changes

@ssyno ssyno ssyno approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SgtCoDFish @FlorianLiebhart @erikgb @munnerz @PT-GD @ssyno