Removing the 'concepts' > 'Certificate' page #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'Requesting Certificates' > 'Certificate' page Signed-off-by: Tim Ramlot <[email protected]>
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
move_concepts_certificate
branch
from
9374a4e to
b8c4acc
Compare
wallrj
approved these changes
Nov 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
wallrj
reviewed
Nov 28, 2023
| @@ -105,7 +105,7 @@ This condition should only be set by an approver. | |||
| namely: `username`, `groups`, `uid`, and `extra`. These values contain the user | |||
| who created the `CertificateRequest`. This user will be cert-manager itself in | |||
| the case that the `CertificateRequest` was created by a | |||
| [`Certificate`](./certificate.md) resource, or instead the user who created the | |||
| [`Certificate`](../usage/certificate.md) resource, or instead the user who created the | |||
There was a problem hiding this comment.
This link change is unnecessary, I think.
wallrj
reviewed
Nov 28, 2023
| @@ -102,7 +102,7 @@ trigger Certificate resources to be automatically created: | |||
| This annotation will also add the annotation | |||
| `"cert-manager.io/issue-temporary-certificate": "true"` onto created | |||
| certificates which will cause a [temporary | |||
| certificate](./certificate.md#temporary-certificates-whilst-issuing) to be set | |||
| certificate](../usage/certificate.md#temporary-certificates-whilst-issuing) to be set | |||
There was a problem hiding this comment.
This change is also unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved remaining unique info to the 'Requesting Certificates' > 'Certificate' page.