Add docs, release notes and upgrade docs for cert-manager v1.17 #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
SgtCoDFish
force-pushed
the
cert-manager-v1.17
branch
from
f87b509 to
c3fbaee
Compare
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
SgtCoDFish
force-pushed
the
cert-manager-v1.17
branch
from
c3fbaee to
c9ad2b7
Compare
|
/hold Shouldn't merge until the release of v1.17 |
cert-manager-prow
bot
added
the
do-not-merge/hold
Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
cert-manager-v1.17
branch
2 times, most recently
from
e653238 to
c38f7fe
Compare
Signed-off-by: Ashley Davis <[email protected]>
SgtCoDFish
force-pushed
the
cert-manager-v1.17
branch
from
c38f7fe to
6cbc7dd
Compare
I used GitHub Copilot in VSCode, more specifically "Send to Copilot Edits", selected the two files, and asked Copilot "fix typos and mistakes". Signed-off-by: Maël Valais <[email protected]>
|
Hey. All good, I propose a few nits in SgtCoDFish#1. /hold if you want to merge the proposed changes |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Edited release notes + upgrade docs for 1.17
|
/unhold |
cert-manager-prow
bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit, since each commit is self contained. The
run ./scripts/freeze-docs 1.16commit is mostly generated from that script and so is probably less in need of review.